Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-20035 Stabilize the flaky TestQuotaStatusRPCs 

The test will fail if the quota moves to violation before
the second half of the test.

Signed-off-by: Michael Stack <stack@apache.org>
This commit is contained in:
Josh Elser 2018-02-21 17:17:57 -05:00
parent 2440f807bf
commit 4cf846d085
1 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestQuotaStatusRPCs.java
View File

@ -199,8 +199,11 @@ public class TestQuotaStatusRPCs {
@Test @Test
public void testQuotaStatusFromMaster() throws Exception { public void testQuotaStatusFromMaster() throws Exception {
final long sizeLimit = 1024L * 10L; // 10KB final long sizeLimit = 1024L * 25L; // 25KB
final long tableSize = 1024L * 5; // 5KB // As of 2.0.0-beta-2, this 1KB of "Cells" actually results in about 15KB on disk (HFiles)
// This is skewed a bit since we're writing such little data, so the test needs to keep
// this in mind; else, the quota will be in violation before the test expects it to be.
final long tableSize = 1024L * 1; // 1KB
final long nsLimit = Long.MAX_VALUE; final long nsLimit = Long.MAX_VALUE;
final int numRegions = 10; final int numRegions = 10;
final TableName tn = helper.createTableWithRegions(numRegions); final TableName tn = helper.createTableWithRegions(numRegions);
@ -245,6 +248,12 @@ public class TestQuotaStatusRPCs {
} }
}); });
// Sanity check: the below assertions will fail if we somehow write too much data
// and force the table to move into violation before we write the second bit of data.
SpaceQuotaSnapshot snapshot = QuotaTableUtil.getCurrentSnapshot(conn, tn);
assertTrue("QuotaSnapshot for " + tn + " should be non-null and not in violation",
snapshot != null && !snapshot.getQuotaStatus().isInViolation());
try { try {
helper.writeData(tn, tableSize * 2L); helper.writeData(tn, tableSize * 2L);
} catch (RetriesExhaustedWithDetailsException | SpaceLimitingException e) { } catch (RetriesExhaustedWithDetailsException | SpaceLimitingException e) {