From 4d7e5992cfe949e7aa8c1326ce247011af14a6fd Mon Sep 17 00:00:00 2001 From: Jerry He Date: Fri, 1 Jul 2016 22:47:51 -0700 Subject: [PATCH] Revert "Log the underlying RPC exception in RpcRetryingCallerImpl": missing HBASE-16149 --- .../apache/hadoop/hbase/client/RpcRetryingCaller.java | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCaller.java b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCaller.java index 6f587d132d6..76261b2a2b7 100644 --- a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCaller.java +++ b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCaller.java @@ -139,17 +139,16 @@ public class RpcRetryingCaller { throw e; } catch (Throwable t) { ExceptionUtil.rethrowIfInterrupt(t); - - // translateException throws exception when should not retry: i.e. when request is bad. - interceptor.handleFailure(context, t); - t = translateException(t); if (tries > startLogErrorsCnt) { LOG.info("Call exception, tries=" + tries + ", retries=" + retries + ", started=" + (EnvironmentEdgeManager.currentTime() - this.globalStartTime) + " ms ago, " + "cancelled=" + cancelled.get() + ", msg=" - + t.getMessage() + " " + callable.getExceptionMessageAdditionalDetail()); + + callable.getExceptionMessageAdditionalDetail()); } + // translateException throws exception when should not retry: i.e. when request is bad. + interceptor.handleFailure(context, t); + t = translateException(t); callable.throwable(t, retries != 1); RetriesExhaustedException.ThrowableWithExtraContext qt = new RetriesExhaustedException.ThrowableWithExtraContext(t, @@ -167,7 +166,7 @@ public class RpcRetryingCaller { long duration = singleCallDuration(expectedSleep); if (duration > callTimeout) { String msg = "callTimeout=" + callTimeout + ", callDuration=" + duration + - ": " + t.getMessage() + " " + callable.getExceptionMessageAdditionalDetail(); + ": " + callable.getExceptionMessageAdditionalDetail(); throw (SocketTimeoutException)(new SocketTimeoutException(msg).initCause(t)); } } finally {