Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-26814 Addendum: Fix spotbugs warning and clarify intent (#4201) 

Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
Signed-off-by: Andrew Purtell <apurtell@apache.org>
This commit is contained in:
Bryan Beaudreault 2022-03-10 13:09:51 -05:00 committed by GitHub
parent be0afbf23a
commit 4da53efcf9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/throttle/StoreHotnessProtector.java
View File

@ -63,7 +63,6 @@ import org.slf4j.LoggerFactory;
public class StoreHotnessProtector { public class StoreHotnessProtector {
private static final Logger LOG = LoggerFactory.getLogger(StoreHotnessProtector.class); private static final Logger LOG = LoggerFactory.getLogger(StoreHotnessProtector.class);
// We want to log just once so that users are aware of this tool
private static volatile boolean loggedDisableMessage; private static volatile boolean loggedDisableMessage;
private volatile int parallelPutToStoreThreadLimit; private volatile int parallelPutToStoreThreadLimit;
@ -98,12 +97,23 @@ public class StoreHotnessProtector {
conf.getInt(PARALLEL_PUT_STORE_THREADS_LIMIT_MIN_COLUMN_COUNT, conf.getInt(PARALLEL_PUT_STORE_THREADS_LIMIT_MIN_COLUMN_COUNT,
DEFAULT_PARALLEL_PUT_STORE_THREADS_LIMIT_MIN_COLUMN_NUM); DEFAULT_PARALLEL_PUT_STORE_THREADS_LIMIT_MIN_COLUMN_NUM);
if (!isEnable() && !loggedDisableMessage) { if (!isEnable()) {
loggedDisableMessage = true; logDisabledMessageOnce();
}
}
/**
* {@link #init(Configuration)} is called for every Store that opens on a RegionServer.
* Here we make a lightweight attempt to log this message once per RegionServer, rather than
* per-Store. The goal is just to draw attention to this feature if debugging overload due to
* heavy writes.
*/
private static void logDisabledMessageOnce() {
if (!loggedDisableMessage) {
LOG.info("StoreHotnessProtector is disabled. Set {} > 0 to enable, " LOG.info("StoreHotnessProtector is disabled. Set {} > 0 to enable, "
+ "which may help mitigate load under heavy write pressure.", + "which may help mitigate load under heavy write pressure.",
PARALLEL_PUT_STORE_THREADS_LIMIT); PARALLEL_PUT_STORE_THREADS_LIMIT);
loggedDisableMessage = true;
} }
} }