Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-27339 Improve sasl connection failure log message to include server (#4823) 

Include the remote server name in the logged exception message when the
connection setup fails in BlockingRpcConnection.

Add an equivalent log line in NettyRpcConnection.

Signed-off-by: Viraj Jasani <vjasani@apache.org>

Conflicts:
	hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java
This commit is contained in:
Andrew Purtell 2022-10-11 10:19:07 -07:00
parent 5a88745994
commit 4ec7ee5cb1
2 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/BlockingRpcConnection.java
View File

@ -392,7 +392,8 @@ class BlockingRpcConnection extends RpcConnection implements Runnable {
// A provider which failed authentication, but doesn't have the ability to relogin with // A provider which failed authentication, but doesn't have the ability to relogin with
// some external system (e.g. username/password, the password either works or it doesn't) // some external system (e.g. username/password, the password either works or it doesn't)
if (!provider.canRetry()) { if (!provider.canRetry()) {
LOG.warn("Exception encountered while connecting to the server : " + ex); LOG.warn("Exception encountered while connecting to the server " + remoteId.getAddress(),
ex);
if (ex instanceof RemoteException) { if (ex instanceof RemoteException) {
throw (RemoteException) ex; throw (RemoteException) ex;
} }
@ -407,7 +408,8 @@ class BlockingRpcConnection extends RpcConnection implements Runnable {
// Other providers, like kerberos, could request a new ticket from a keytab. Let // Other providers, like kerberos, could request a new ticket from a keytab. Let
// them try again. // them try again.
if (currRetries < maxRetries) { if (currRetries < maxRetries) {
LOG.debug("Exception encountered while connecting to the server", ex); LOG.debug("Exception encountered while connecting to the server " + remoteId.getAddress(),
ex);
// Invoke the provider to perform the relogin // Invoke the provider to perform the relogin
provider.relogin(); provider.relogin();

5
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java
View File

@ -290,7 +290,10 @@ class NettyRpcConnection extends RpcConnection {
public void operationComplete(ChannelFuture future) throws Exception { public void operationComplete(ChannelFuture future) throws Exception {
Channel ch = future.channel(); Channel ch = future.channel();
if (!future.isSuccess()) { if (!future.isSuccess()) {
failInit(ch, toIOE(future.cause())); IOException ex = toIOE(future.cause());
LOG.warn(
"Exception encountered while connecting to the server " + remoteId.getAddress(), ex);
failInit(ch, ex);
rpcClient.failedServers.addToFailedServers(remoteId.address, future.cause()); rpcClient.failedServers.addToFailedServers(remoteId.address, future.cause());
return; return;
} }