Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-14930 check_compatibility.sh needs smarter exit codes 

Signed-off-by: Andrew Purtell <apurtell@apache.org>
This commit is contained in:
Dima Spivak 2015-12-04 11:36:16 -08:00 committed by Andrew Purtell
parent c9a0148628
commit 4f36632d7b
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
dev-support/check_compatibility.sh
View File

@ -93,7 +93,7 @@ if ! ARG_LIST=$(${GETOPT} -q -o abfhno:qr:s \
-l all,binary-only,force-download,help,no-checkout,options:,quick,repo:,source-only \ -l all,binary-only,force-download,help,no-checkout,options:,quick,repo:,source-only \
-- "${@}"); then -- "${@}"); then
usage >&2 usage >&2
exit 1 exit 2
fi fi
eval set -- "${ARG_LIST[@]}" eval set -- "${ARG_LIST[@]}"
@ -145,7 +145,7 @@ while ((${#})); do
# message. # message.
else else
usage >&2 usage >&2
exit 1 exit 2
fi fi
;; ;;
esac esac
@ -166,7 +166,7 @@ for ref in 1 2; do
echo "Cloning ${REPO_URL} into ${SCRIPT_DIRECTORY}/target/compatibility/${ref}..." echo "Cloning ${REPO_URL} into ${SCRIPT_DIRECTORY}/target/compatibility/${ref}..."
if ! git clone ${REPO_URL} ${SCRIPT_DIRECTORY}/target/compatibility/${ref}; then if ! git clone ${REPO_URL} ${SCRIPT_DIRECTORY}/target/compatibility/${ref}; then
echo "Error while cloning ${REPO_URL}. Exiting..." >&2 echo "Error while cloning ${REPO_URL}. Exiting..." >&2
exit 1 exit 2
fi fi
elif [ "${ref}" = "2" ]; then elif [ "${ref}" = "2" ]; then
# Avoid cloning from Git twice by copying first repo into different folder. # Avoid cloning from Git twice by copying first repo into different folder.
@ -181,12 +181,12 @@ for ref in 1 2; do
echo "Checking out ${COMMIT[${ref}]} into ${ref}/..." echo "Checking out ${COMMIT[${ref}]} into ${ref}/..."
if ! git checkout -f ${COMMIT[${ref}]}; then if ! git checkout -f ${COMMIT[${ref}]}; then
echo "Error while checking out ${COMMIT[${ref}]}. Exiting..." >&2 echo "Error while checking out ${COMMIT[${ref}]}. Exiting..." >&2
exit 1 exit 2
fi fi
echo "Building ${COMMIT[${ref}]}..." echo "Building ${COMMIT[${ref}]}..."
if ! mvn clean package -DskipTests; then if ! mvn clean package -DskipTests; then
echo "Maven could not successfully package ${COMMIT[${ref}]}. Exiting..." >&2 echo "Maven could not successfully package ${COMMIT[${ref}]}. Exiting..." >&2
exit 1 exit 2
fi fi
popd > /dev/null popd > /dev/null
fi fi
@ -205,7 +205,7 @@ for ref in 1 2; do
"Attempting to build ${COMMIT[${ref}]}..." "Attempting to build ${COMMIT[${ref}]}..."
if ! mvn clean package -DskipTests; then if ! mvn clean package -DskipTests; then
echo "Maven could not successfully package ${COMMIT[${ref}]}. Exiting..." >&2 echo "Maven could not successfully package ${COMMIT[${ref}]}. Exiting..." >&2
exit 1 exit 2
fi fi
popd > /dev/null popd > /dev/null
done done
@ -213,7 +213,7 @@ for ref in 1 2; do
JARS=$(find ${SCRIPT_DIRECTORY}/target/compatibility/${ref} "${JAR_FIND_EXPRESSION[@]}") JARS=$(find ${SCRIPT_DIRECTORY}/target/compatibility/${ref} "${JAR_FIND_EXPRESSION[@]}")
if [ ${#JARS[@]} -eq 0 ]; then if [ ${#JARS[@]} -eq 0 ]; then
echo "Unable to find any JARs matching the find expression. Exiting..." >&2 echo "Unable to find any JARs matching the find expression. Exiting..." >&2
exit 1 exit 2
fi fi
# If no JARs were found and --no-checkout was not specified, fail immediately. # If no JARs were found and --no-checkout was not specified, fail immediately.
@ -242,7 +242,7 @@ if [ ! -d ${SCRIPT_DIRECTORY}/target/compatibility/javaACC ] || [ -n "${FORCE_DO
if ! git clone https://github.com/lvc/japi-compliance-checker.git \ if ! git clone https://github.com/lvc/japi-compliance-checker.git \
${SCRIPT_DIRECTORY}/target/compatibility/javaACC; then ${SCRIPT_DIRECTORY}/target/compatibility/javaACC; then
echo "Failed to download Java API Compliance Checker. Exiting..." >&2 echo "Failed to download Java API Compliance Checker. Exiting..." >&2
exit 1 exit 2
fi fi
fi fi