Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-15673 Fix latency metrics for multiGet. - Also fixes some stuff in help text. (Apekshit) 

Change-Id: I49d76896d5cc070b9f60dadf6746865e98fbbbd0

Signed-off-by: stack <stack@apache.org>
This commit is contained in:
Apekshit 2016-04-18 15:56:42 -07:00 committed by stack
parent bd3b9753a9
commit 501030d204
1 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
hbase-server/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java
View File

@ -1143,7 +1143,12 @@ public class PerformanceEvaluation extends Configured implements Tool {
scope.close(); scope.close();
} }
if ( (i - startRow) > opts.measureAfter) { if ( (i - startRow) > opts.measureAfter) {
latencyHistogram.update((System.nanoTime() - startTime) / 1000); // If multiget is enabled, say set to 10, testRow() returns immediately first 9 times
// and sends the actual get request in the 10th iteration. We should only set latency
// when actual request is sent because otherwise it turns out to be 0.
if (opts.multiGet == 0 || (i - startRow + 1) % opts.multiGet == 0) {
latencyHistogram.update((System.nanoTime() - startTime) / 1000);
}
if (status != null && i > 0 && (i % getReportingPeriod()) == 0) { if (status != null && i > 0 && (i % getReportingPeriod()) == 0) {
status.setStatus(generateStatus(startRow, i, lastRow)); status.setStatus(generateStatus(startRow, i, lastRow));
} }
@ -1826,6 +1831,8 @@ public class PerformanceEvaluation extends Configured implements Tool {
+ DEFAULT_OPTS.getValueSize()); + DEFAULT_OPTS.getValueSize());
System.err.println(" valueRandom Set if we should vary value size between 0 and " + System.err.println(" valueRandom Set if we should vary value size between 0 and " +
"'valueSize'; set on read for stats on size: Default: Not set."); "'valueSize'; set on read for stats on size: Default: Not set.");
System.err.println(" blockEncoding Block encoding to use. Value should be one of "
+ Arrays.toString(DataBlockEncoding.values()) + ". Default: NONE");
System.err.println(); System.err.println();
System.err.println("Table Creation / Write Tests:"); System.err.println("Table Creation / Write Tests:");
System.err.println(" table Alternate table name. Default: 'TestTable'"); System.err.println(" table Alternate table name. Default: 'TestTable'");
@ -1840,12 +1847,13 @@ public class PerformanceEvaluation extends Configured implements Tool {
"'valueSize' in zipf form: Default: Not set."); "'valueSize' in zipf form: Default: Not set.");
System.err.println(" writeToWAL Set writeToWAL on puts. Default: True"); System.err.println(" writeToWAL Set writeToWAL on puts. Default: True");
System.err.println(" autoFlush Set autoFlush on htable. Default: False"); System.err.println(" autoFlush Set autoFlush on htable. Default: False");
System.err.println(" presplit Create presplit table. Recommended for accurate perf " + System.err.println(" presplit Create presplit table. If a table with same name exists,"
"analysis (see guide). Default: disabled"); + " it'll be deleted and recreated (instead of verifying count of its existing regions). "
+ "Recommended for accurate perf analysis (see guide). Default: disabled");
System.err.println(" usetags Writes tags along with KVs. Use with HFile V3. " + System.err.println(" usetags Writes tags along with KVs. Use with HFile V3. " +
"Default: false"); "Default: false");
System.err.println(" numoftags Specify the no of tags that would be needed. " + System.err.println(" numoftags Specify the no of tags that would be needed. " +
"This works only if usetags is true."); "This works only if usetags is true. Default: " + DEFAULT_OPTS.noOfTags);
System.err.println(" splitPolicy Specify a custom RegionSplitPolicy for the table."); System.err.println(" splitPolicy Specify a custom RegionSplitPolicy for the table.");
System.err.println(" columns Columns to write per row. Default: 1"); System.err.println(" columns Columns to write per row. Default: 1");
System.err.println(); System.err.println();