Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-7506 Judgment of carrying ROOT/META will become wrong when expiring server (Chunhui) 

git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1431901 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
zjushch 2013-01-11 05:47:18 +00:00
parent fcc11f61e5
commit 50bac9f397
2 changed files with 25 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
View File

@ -2636,11 +2636,11 @@ public class AssignmentManager extends ZooKeeperListener {
threadPoolExecutorService.submit(new UnAssignCallable(this, regionInfo)); threadPoolExecutorService.submit(new UnAssignCallable(this, regionInfo));
} }
boolean isCarryingRoot(ServerName serverName) { public boolean isCarryingRoot(ServerName serverName) {
return isCarryingRegion(serverName, HRegionInfo.ROOT_REGIONINFO); return isCarryingRegion(serverName, HRegionInfo.ROOT_REGIONINFO);
} }
boolean isCarryingMeta(ServerName serverName) { public boolean isCarryingMeta(ServerName serverName) {
return isCarryingRegion(serverName, HRegionInfo.FIRST_META_REGIONINFO); return isCarryingRegion(serverName, HRegionInfo.FIRST_META_REGIONINFO);
} }

33
hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdownHandler.java
View File

@ -196,20 +196,33 @@ public class ServerShutdownHandler extends EventHandler {
// Assign root and meta if we were carrying them. // Assign root and meta if we were carrying them.
if (isCarryingRoot()) { // -ROOT- if (isCarryingRoot()) { // -ROOT-
LOG.info("Server " + serverName + // Check again: region may be assigned to other where because of RIT
" was carrying ROOT. Trying to assign."); // timeout
this.services.getAssignmentManager(). if (this.services.getAssignmentManager().isCarryingRoot(serverName)) {
regionOffline(HRegionInfo.ROOT_REGIONINFO); LOG.info("Server " + serverName
verifyAndAssignRootWithRetries(); + " was carrying ROOT. Trying to assign.");
this.services.getAssignmentManager().regionOffline(
HRegionInfo.ROOT_REGIONINFO);
verifyAndAssignRootWithRetries();
} else {
LOG.info("ROOT has been assigned to otherwhere, skip assigning.");
}
} }
// Carrying meta? // Carrying meta?
if (isCarryingMeta()) { if (isCarryingMeta()) {
LOG.info("Server " + serverName + // Check again: region may be assigned to other where because of RIT
" was carrying META. Trying to assign."); // timeout
this.services.getAssignmentManager(). if (this.services.getAssignmentManager().isCarryingMeta(serverName)) {
regionOffline(HRegionInfo.FIRST_META_REGIONINFO); LOG.info("Server " + serverName
this.services.getAssignmentManager().assignMeta(); + " was carrying META. Trying to assign.");
this.services.getAssignmentManager().regionOffline(
HRegionInfo.FIRST_META_REGIONINFO);
this.services.getAssignmentManager().assignMeta();
} else {
LOG.info("META has been assigned to otherwhere, skip assigning.");
}
} }
// We don't want worker thread in the MetaServerShutdownHandler // We don't want worker thread in the MetaServerShutdownHandler