Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-25927: Fix the log messages by not stringifying the exceptions in log (#3338) 

Signed-off-by: Bharath Vissapragada <bharathv@apache.org>
(cherry picked from commit 9a2027bf71)
This commit is contained in:
Sandeep Pal 2021-05-28 21:28:19 -07:00 committed by Bharath Vissapragada
parent 2a84fd40d3
commit 5157521213
No known key found for this signature in database
GPG Key ID: 18AE42A0B5A93FA7
4 changed files with 10 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/RecoveredReplicationSourceShipper.java
View File

@ -66,7 +66,7 @@ public class RecoveredReplicationSourceShipper extends ReplicationSourceShipper
source.locateRecoveredPaths(walGroupId); source.locateRecoveredPaths(walGroupId);
break; break;
} catch (IOException e) { } catch (IOException e) {
LOG.error("Error while locating recovered queue paths, attempt #" + numRetries); LOG.error("Error while locating recovered queue paths, attempt #" + numRetries, e);
numRetries++; numRetries++;
} }
} }

4
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
View File

@ -658,8 +658,8 @@ public class ReplicationSource implements ReplicationSourceInterface {
if (cause == null) { if (cause == null) {
LOG.info("{} Closing source {} because: {}", logPeerId(), this.queueId, reason); LOG.info("{} Closing source {} because: {}", logPeerId(), this.queueId, reason);
} else { } else {
LOG.error("{} Closing source {} because an error occurred: {}", LOG.error(String.format("%s Closing source %s because an error occurred: %s",
logPeerId(), this.queueId, reason, cause); logPeerId(), this.queueId, reason), cause);
} }
this.sourceRunning = false; this.sourceRunning = false;
if (initThread != null && Thread.currentThread() != initThread) { if (initThread != null && Thread.currentThread() != initThread) {

6
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java
View File

@ -753,8 +753,8 @@ public class ReplicationSourceManager implements ReplicationListener {
LOG.error(String.format("ReplicationException: cannot claim dead region (%s)'s " + LOG.error(String.format("ReplicationException: cannot claim dead region (%s)'s " +
"replication queue. Znode : (%s)" + "replication queue. Znode : (%s)" +
" Possible solution: check if znode size exceeds jute.maxBuffer value. " + " Possible solution: check if znode size exceeds jute.maxBuffer value. " +
" If so, increase it for both client and server side." + e), deadRS, " If so, increase it for both client and server side.",
queueStorage.getRsNode(deadRS)); deadRS, queueStorage.getRsNode(deadRS)), e);
server.abort("Failed to claim queue from dead regionserver.", e); server.abort("Failed to claim queue from dead regionserver.", e);
return; return;
} }
@ -1008,7 +1008,7 @@ public class ReplicationSourceManager implements ReplicationListener {
* This ReplicationSource is NOT created via {@link ReplicationSourceFactory}. * This ReplicationSource is NOT created via {@link ReplicationSourceFactory}.
* @see #addSource(String) This is a specialization of the addSource call. * @see #addSource(String) This is a specialization of the addSource call.
* @see #catalogReplicationSource for a note on this ReplicationSource's lifecycle (and more on * @see #catalogReplicationSource for a note on this ReplicationSource's lifecycle (and more on
* why the special handling). * why the special handling).
*/ */
private ReplicationSourceInterface createCatalogReplicationSource(RegionInfo regionInfo) private ReplicationSourceInterface createCatalogReplicationSource(RegionInfo regionInfo)
throws IOException { throws IOException {

9
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceWALReader.java
View File

@ -172,7 +172,7 @@ class ReplicationSourceWALReader extends Thread {
} }
} catch (IOException e) { } catch (IOException e) {
if (sleepMultiplier < maxRetriesMultiplier) { if (sleepMultiplier < maxRetriesMultiplier) {
LOG.debug("Failed to read stream of replication entries: " + e); LOG.debug("Failed to read stream of replication entries: ", e);
sleepMultiplier++; sleepMultiplier++;
} else { } else {
LOG.error("Failed to read stream of replication entries", e); LOG.error("Failed to read stream of replication entries", e);
@ -306,7 +306,7 @@ class ReplicationSourceWALReader extends Thread {
return true; return true;
} }
} catch (IOException ioe) { } catch (IOException ioe) {
LOG.warn("Couldn't get file length information about log {}", queue.peek()); LOG.warn("Couldn't get file length information about log " + queue.peek(), ioe);
} }
} }
return false; return false;
@ -420,7 +420,7 @@ class ReplicationSourceWALReader extends Thread {
} }
} catch (IOException e) { } catch (IOException e) {
LOG.error("Failed to deserialize bulk load entry from wal edit. " LOG.error("Failed to deserialize bulk load entry from wal edit. "
+ "Then its hfiles count will not be added into metric."); + "Then its hfiles count will not be added into metric.", e);
} }
} }
@ -457,8 +457,7 @@ class ReplicationSourceWALReader extends Thread {
} catch (IOException e) { } catch (IOException e) {
LOG.error("Failed to deserialize bulk load entry from wal edit. " LOG.error("Failed to deserialize bulk load entry from wal edit. "
+ "Size of HFiles part of cell will not be considered in replication " + "Size of HFiles part of cell will not be considered in replication "
+ "request size calculation.", + "request size calculation.", e);
e);
} }
} }
} }