From 5197640c3095c2a0d4ca0b78361fa5645f54a0e2 Mon Sep 17 00:00:00 2001
From: Matteo Bertozzi <matteo.bertozzi@cloudera.com>
Date: Mon, 9 Mar 2015 19:47:27 +0000
Subject: [PATCH] HBASE-13179 TestMasterObserver deleteTable is flaky

---
 .../hbase/coprocessor/TestMasterObserver.java | 23 +++++++++++++++----
 1 file changed, 18 insertions(+), 5 deletions(-)

diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java
index 7b0594cf7c7..c85ba831946 100644
--- a/hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java
+++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java
@@ -75,6 +75,7 @@ public class TestMasterObserver {
   private static final Log LOG = LogFactory.getLog(TestMasterObserver.class);
 
   public static CountDownLatch tableCreationLatch = new CountDownLatch(1);
+  public static CountDownLatch tableDeletionLatch = new CountDownLatch(1);
 
   public static class CPMasterObserver implements MasterObserver {
 
@@ -854,6 +855,7 @@ public class TestMasterObserver {
         ObserverContext<MasterCoprocessorEnvironment> ctx, TableName tableName)
         throws IOException {
       postDeleteTableHandlerCalled = true;
+      tableDeletionLatch.countDown();
     }
 
     public boolean wasDeleteTableHandlerCalled() {
@@ -1212,7 +1214,7 @@ public class TestMasterObserver {
     // delete table
     admin.disableTable(tableName);
     assertTrue(admin.isTableDisabled(tableName));
-    admin.deleteTable(tableName);
+    deleteTable(admin, tableName);
     assertFalse("Test table should have been deleted",
         admin.tableExists(tableName));
     // preDeleteTable can't bypass default action.
@@ -1295,7 +1297,7 @@ public class TestMasterObserver {
     assertFalse("No table deleted yet", cp.wasDeleteTableCalled());
     assertFalse("Delete table handler should not be called.",
         cp.wasDeleteTableHandlerCalled());
-    admin.deleteTable(tableName);
+    deleteTable(admin, tableName);
     assertFalse("Test table should have been deleted",
         admin.tableExists(tableName));
     assertTrue("Coprocessor should have been called on table delete",
@@ -1343,7 +1345,7 @@ public class TestMasterObserver {
         cp.wasRestoreSnapshotCalled());
       admin.disableTable(TEST_CLONE);
       assertTrue(admin.isTableDisabled(tableName));
-      admin.deleteTable(TEST_CLONE);
+      deleteTable(admin, TEST_CLONE);
 
       // Test restore operation
       cp.resetStates();
@@ -1357,7 +1359,7 @@ public class TestMasterObserver {
       assertTrue("Coprocessor should have been called on snapshot delete",
         cp.wasDeleteSnapshotCalled());
     } finally {
-      admin.deleteTable(tableName);
+      deleteTable(admin, tableName);
     }
   }
 
@@ -1537,7 +1539,9 @@ public class TestMasterObserver {
       assertTrue("Coprocessor should be called on region rebalancing",
           cp.wasBalanceCalled());
     } finally {
-      UTIL.deleteTable(tableName);
+      Admin admin = UTIL.getHBaseAdmin();
+      admin.disableTable(tableName);
+      deleteTable(admin, tableName);
     }
   }
 
@@ -1584,4 +1588,13 @@ public class TestMasterObserver {
     assertTrue("Coprocessor should be called on table names request",
       cp.wasGetTableNamesCalled());
   }
+
+  private void deleteTable(Admin admin, TableName tableName) throws Exception {
+    // NOTE: We need a latch because admin is not sync,
+    // so the postOp coprocessor method may be called after the admin operation returned.
+    tableDeletionLatch = new CountDownLatch(1);
+    admin.deleteTable(tableName);
+    tableDeletionLatch.await();
+    tableDeletionLatch = new CountDownLatch(1);
+  }
 }