Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-16532 Procedure-V2: Enforce procedure ownership at submission

This commit is contained in:
tedyu 2016-08-31 12:55:54 -07:00
parent 605af95132
commit 5376106d05
2 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/ProcedureExecutor.java
View File

@ -246,6 +246,9 @@ public class ProcedureExecutor<TEnvironment> {
private final ProcedureStore store; private final ProcedureStore store;
private final Configuration conf; private final Configuration conf;
private static final String CHECK_OWNER_SET_CONF_KEY = "hbase.procedure.check.owner.set";
private final boolean checkOwnerSet;
private Thread[] threads; private Thread[] threads;
public ProcedureExecutor(final Configuration conf, final TEnvironment environment, public ProcedureExecutor(final Configuration conf, final TEnvironment environment,
@ -259,6 +262,7 @@ public class ProcedureExecutor<TEnvironment> {
this.runnables = runqueue; this.runnables = runqueue;
this.store = store; this.store = store;
this.conf = conf; this.conf = conf;
this.checkOwnerSet = conf.getBoolean(CHECK_OWNER_SET_CONF_KEY, true);
} }
private void load(final boolean abortOnCorruption) throws IOException { private void load(final boolean abortOnCorruption) throws IOException {
@ -640,6 +644,9 @@ public class ProcedureExecutor<TEnvironment> {
Preconditions.checkArgument(isRunning()); Preconditions.checkArgument(isRunning());
Preconditions.checkArgument(lastProcId.get() >= 0); Preconditions.checkArgument(lastProcId.get() >= 0);
Preconditions.checkArgument(!proc.hasParent()); Preconditions.checkArgument(!proc.hasParent());
if (this.checkOwnerSet) {
Preconditions.checkArgument(proc.hasOwner());
}
// Initialize the Procedure ID // Initialize the Procedure ID
long currentProcId = nextProcId(); long currentProcId = nextProcId();

7
hbase-procedure/src/test/resources/hbase-site.xml
View File

@ -25,4 +25,11 @@
<name>hbase.procedure.store.wal.use.hsync</name> <name>hbase.procedure.store.wal.use.hsync</name>
<value>false</value> <value>false</value>
</property> </property>
<property>
<name>hbase.procedure.check.owner.set</name>
<value>false</value>
<description>Whether ProcedureExecutor should enforce that each
procedure to have an owner
</description>
</property>
</configuration> </configuration>