From 53a8c2675f3afd44ab8fbb87e3414e2ba29bf544 Mon Sep 17 00:00:00 2001
From: Braavos <35978114+Braavos96@users.noreply.github.com>
Date: Wed, 10 Jul 2019 09:07:55 +0100
Subject: [PATCH] HBASE-22669 Add unit tests for
 org.apache.hadoop.hbase.util.Strings (#363)

These tests were written using Diffblue Cover.
---
 .../apache/hadoop/hbase/util/TestStrings.java | 71 +++++++++++++++++++
 1 file changed, 71 insertions(+)
 create mode 100644 hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestStrings.java

diff --git a/hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestStrings.java b/hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestStrings.java
new file mode 100644
index 00000000000..93e19157d75
--- /dev/null
+++ b/hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestStrings.java
@@ -0,0 +1,71 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ * <p>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.util;
+
+import org.apache.hadoop.hbase.HBaseClassTestRule;
+import org.apache.hadoop.hbase.testclassification.SmallTests;
+import org.junit.Assert;
+import org.junit.ClassRule;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.junit.rules.ExpectedException;
+
+@Category({SmallTests.class})
+public class TestStrings {
+
+  @Rule
+  public final ExpectedException thrown = ExpectedException.none();
+
+  @ClassRule
+  public static final HBaseClassTestRule CLASS_RULE =
+          HBaseClassTestRule.forClass(TestStrings.class);
+
+  @Test
+  public void testAppendKeyValue() {
+    Assert.assertEquals("foo, bar=baz", Strings.appendKeyValue(
+            new StringBuilder("foo"), "bar", "baz").toString());
+    Assert.assertEquals("bar->baz", Strings.appendKeyValue(
+            new StringBuilder(), "bar", "baz", "->", "| ").toString());
+    Assert.assertEquals("foo, bar=baz", Strings.appendKeyValue(
+            new StringBuilder("foo"), "bar", "baz", "=", ", ").toString());
+    Assert.assertEquals("foo| bar->baz", Strings.appendKeyValue(
+            new StringBuilder("foo"), "bar", "baz", "->", "| ").toString());
+  }
+
+  @Test
+  public void testDomainNamePointerToHostName() {
+    Assert.assertNull(Strings.domainNamePointerToHostName(null));
+    Assert.assertEquals("foo",
+            Strings.domainNamePointerToHostName("foo"));
+    Assert.assertEquals("foo.com",
+            Strings.domainNamePointerToHostName("foo.com"));
+    Assert.assertEquals("foo.bar.com",
+            Strings.domainNamePointerToHostName("foo.bar.com"));
+    Assert.assertEquals("foo.bar.com",
+            Strings.domainNamePointerToHostName("foo.bar.com."));
+  }
+
+  @Test
+  public void testPadFront() {
+    Assert.assertEquals("ddfoo", Strings.padFront("foo", 'd', 5));
+
+    thrown.expect(IllegalArgumentException.class);
+    Strings.padFront("foo", 'd', 1);
+  }
+}