HBASE-27365 Minimise block addition failures due to no space in bucket cache writers queue by introducing wait time - addendum added mistakenly removed in-memory flag
This commit is contained in:
parent
ced1d642ae
commit
54a82302b4
|
@ -1342,7 +1342,8 @@ public abstract class HFileReaderImpl implements HFile.Reader, Configurable {
|
||||||
cacheConf.getBlockCache().ifPresent(cache -> {
|
cacheConf.getBlockCache().ifPresent(cache -> {
|
||||||
if (cacheBlock && cacheConf.shouldCacheBlockOnRead(category)) {
|
if (cacheBlock && cacheConf.shouldCacheBlockOnRead(category)) {
|
||||||
// Using the wait on cache during compaction and prefetching.
|
// Using the wait on cache during compaction and prefetching.
|
||||||
cache.cacheBlock(cacheKey, cacheCompressed ? hfileBlock : unpacked, cacheOnly);
|
cache.cacheBlock(cacheKey, cacheCompressed ? hfileBlock : unpacked,
|
||||||
|
cacheConf.isInMemory(), cacheOnly);
|
||||||
}
|
}
|
||||||
});
|
});
|
||||||
if (unpacked != hfileBlock) {
|
if (unpacked != hfileBlock) {
|
||||||
|
|
|
@ -279,7 +279,7 @@
|
||||||
</property>
|
</property>
|
||||||
<property>
|
<property>
|
||||||
<name>hbase.bucketcache.queue.addition.waittime</name>
|
<name>hbase.bucketcache.queue.addition.waittime</name>
|
||||||
<value>100</value>
|
<value>1000</value>
|
||||||
<description>Default is 0</description>
|
<description>Default is 0</description>
|
||||||
</property>
|
</property>
|
||||||
</configuration>
|
</configuration>
|
||||||
|
|
Loading…
Reference in New Issue