Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-9315 TestLruBlockCache.testBackgroundEvictionThread fails on suse 

git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1517868 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Michael Stack 2013-08-27 16:35:54 +00:00
parent 91ef1fda93
commit 54d0f9f800
1 changed files with 25 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

43
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestLruBlockCache.java
View File

@ -22,22 +22,14 @@ import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertTrue; import static org.junit.Assert.assertTrue;
import java.nio.ByteBuffer; import java.nio.ByteBuffer;
import java.util.Collection;
import java.util.Map;
import java.util.Random; import java.util.Random;
import org.apache.hadoop.hbase.HBaseTestingUtility;
import org.apache.hadoop.hbase.SmallTests; import org.apache.hadoop.hbase.SmallTests;
import org.apache.hadoop.hbase.io.HeapSize; import org.apache.hadoop.hbase.io.HeapSize;
import org.apache.hadoop.hbase.io.hfile.LruBlockCache.EvictionThread; import org.apache.hadoop.hbase.io.hfile.LruBlockCache.EvictionThread;
import org.apache.hadoop.hbase.util.ClassSize; import org.apache.hadoop.hbase.util.ClassSize;
import org.junit.After;
import org.junit.Before;
import org.junit.Test; import org.junit.Test;
import org.junit.experimental.categories.Category; import org.junit.experimental.categories.Category;
import org.junit.runner.RunWith;
import org.junit.runners.Parameterized;
import org.junit.runners.Parameterized.Parameters;
/** /**
* Tests the concurrent LruBlockCache.<p> * Tests the concurrent LruBlockCache.<p>
@ -53,36 +45,51 @@ public class TestLruBlockCache {
@Test @Test
public void testBackgroundEvictionThread() throws Exception { public void testBackgroundEvictionThread() throws Exception {
long maxSize = 100000; long maxSize = 100000;
long blockSize = calculateBlockSizeDefault(maxSize, 9); // room for 9, will evict int numBlocks = 9;
long blockSize = calculateBlockSizeDefault(maxSize, numBlocks);
assertTrue("calculateBlockSize appears broken.", blockSize * numBlocks <= maxSize);
LruBlockCache cache = new LruBlockCache(maxSize,blockSize); LruBlockCache cache = new LruBlockCache(maxSize,blockSize);
CachedItem [] blocks = generateFixedBlocks(10, blockSize, "block");
EvictionThread evictionThread = cache.getEvictionThread(); EvictionThread evictionThread = cache.getEvictionThread();
assertTrue(evictionThread != null); assertTrue(evictionThread != null);
CachedItem[] blocks = generateFixedBlocks(numBlocks + 1, blockSize, "block");
// Make sure eviction thread has entered run method // Make sure eviction thread has entered run method
while (!evictionThread.isEnteringRun()) { while (!evictionThread.isEnteringRun()) {
Thread.sleep(1); Thread.sleep(1);
} }
// Add all the blocks // Add all the blocks
for (CachedItem block : blocks) { for (CachedItem block : blocks) {
cache.cacheBlock(block.cacheKey, block); cache.cacheBlock(block.cacheKey, block);
} }
// Let the eviction run // wait until at least one eviction has run
int n = 0; int n = 0;
while(cache.getEvictionCount() == 0) { while(cache.getEvictionCount() == 0) {
Thread.sleep(200); Thread.sleep(200);
assertTrue(n++ < 20); assertTrue("Eviction never happened.", n++ < 20);
} }
System.out.println("Background Evictions run: " + cache.getEvictionCount());
// A single eviction run should have occurred // let cache stabilize
assertEquals(cache.getEvictionCount(), 1); // On some systems, the cache will run multiple evictions before it attains
// steady-state. For instance, after populating the cache with 10 blocks,
// the first eviction evicts a single block and then a second eviction
// evicts another. I think this is due to the delta between minSize and
// acceptableSize, combined with variance between object overhead on
// different environments.
n = 0;
for (long prevCnt = 0 /* < number of blocks added */,
curCnt = cache.getBlockCount();
prevCnt != curCnt; prevCnt = curCnt, curCnt = cache.getBlockCount()) {
Thread.sleep(200);
assertTrue("Cache never stabilized.", n++ < 20);
}
long evictionCount = cache.getEvictionCount();
assertTrue(evictionCount >= 1);
System.out.println("Background Evictions run: " + evictionCount);
} }
@Test @Test