From 559aa12a09e3599bbcb18c7512284384def12f09 Mon Sep 17 00:00:00 2001 From: Enis Soztutar Date: Wed, 19 Jun 2013 18:37:26 +0000 Subject: [PATCH] HBASE-8766 [WINDOWS] bin/hbase.cmd zkcli is broken git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1494732 13f79535-47bb-0310-9956-ffa450edef68 --- bin/hbase | 5 +---- bin/hbase.cmd | 4 +--- ...ServerArg.java => ZooKeeperMainServer.java} | 18 ++++++++---------- ...erArg.java => TestZooKeeperMainServer.java} | 5 ++--- 4 files changed, 12 insertions(+), 20 deletions(-) rename hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/{ZooKeeperMainServerArg.java => ZooKeeperMainServer.java} (79%) rename hbase-server/src/test/java/org/apache/hadoop/hbase/zookeeper/{TestZooKeeperMainServerArg.java => TestZooKeeperMainServer.java} (93%) diff --git a/bin/hbase b/bin/hbase index d29963b9273..0751c2b0366 100755 --- a/bin/hbase +++ b/bin/hbase @@ -273,10 +273,7 @@ elif [ "$COMMAND" = "hlog" ] ; then elif [ "$COMMAND" = "hfile" ] ; then CLASS='org.apache.hadoop.hbase.io.hfile.HFile' elif [ "$COMMAND" = "zkcli" ] ; then - # ZooKeeperMainServerArg returns '-server HOST:PORT' or empty string. - SERVER_ARG=`"$bin"/hbase org.apache.hadoop.hbase.zookeeper.ZooKeeperMainServerArg` - CLASS="org.apache.zookeeper.ZooKeeperMain ${SERVER_ARG}" - + CLASS="org.apache.hadoop.hbase.zookeeper.ZooKeeperMainServer" elif [ "$COMMAND" = "master" ] ; then CLASS='org.apache.hadoop.hbase.master.HMaster' if [ "$1" != "stop" ] ; then diff --git a/bin/hbase.cmd b/bin/hbase.cmd index 0cc9f785aba..9e2de133af7 100644 --- a/bin/hbase.cmd +++ b/bin/hbase.cmd @@ -337,9 +337,7 @@ goto :eof goto :eof :zkcli - rem ZooKeeperMainServerArg returns '-server HOST:PORT' or empty string. - set SERVER_ARG=%HADOOP_BIN_PATH%\hbase org.apache.hadoop.hbase.zookeeper.ZooKeeperMainServerArg - set CLASS=org.apache.zookeeper.ZooKeeperMain %SERVER_ARG% + set CLASS=org.apache.hadoop.hbase.zookeeper.ZooKeeperMainServer goto :eof :makeServiceXml diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperMainServerArg.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperMainServer.java similarity index 79% rename from hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperMainServerArg.java rename to hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperMainServer.java index 26eaab39750..84e303998df 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperMainServerArg.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperMainServer.java @@ -26,15 +26,13 @@ import java.util.Properties; import org.apache.hadoop.conf.Configuration; import org.apache.hadoop.hbase.HBaseConfiguration; +import org.apache.zookeeper.ZooKeeperMain; /** - * Tool for reading a ZooKeeper server from HBase XML configuration producing - * the '-server host:port' argument to pass ZooKeeperMain. This program - * emits either '-server HOST:PORT" where HOST is one of the zk ensemble - * members plus zk client port OR it emits '' if no zk servers found (Yes, - * it emits '-server' too). + * Tool for running ZookeeperMain from HBase by reading a ZooKeeper server + * from HBase XML configuration. */ -public class ZooKeeperMainServerArg { +public class ZooKeeperMainServer { public String parse(final Configuration c) { // Note that we do not simply grab the property // HConstants.ZOOKEEPER_QUORUM from the HBaseConfiguration because the @@ -68,10 +66,10 @@ public class ZooKeeperMainServerArg { * Run the tool. * @param args Command line arguments. First arg is path to zookeepers file. */ - public static void main(String args[]) { + public static void main(String args[]) throws Exception { Configuration conf = HBaseConfiguration.create(); - String hostport = new ZooKeeperMainServerArg().parse(conf); - System.out.println((hostport == null || hostport.length() == 0)? "": - "-server " + hostport); + String hostport = new ZooKeeperMainServer().parse(conf); + String zkArg = (hostport == null || hostport.length() == 0)? "": "-server " + hostport; + ZooKeeperMain.main(new String[] {zkArg}); } } diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZooKeeperMainServerArg.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZooKeeperMainServer.java similarity index 93% rename from hbase-server/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZooKeeperMainServerArg.java rename to hbase-server/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZooKeeperMainServer.java index facc839df49..f7d4c3fed93 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZooKeeperMainServerArg.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZooKeeperMainServer.java @@ -27,8 +27,8 @@ import org.junit.Test; import org.junit.experimental.categories.Category; @Category(SmallTests.class) -public class TestZooKeeperMainServerArg { - private final ZooKeeperMainServerArg parser = new ZooKeeperMainServerArg(); +public class TestZooKeeperMainServer { + private final ZooKeeperMainServer parser = new ZooKeeperMainServer(); @Test public void test() { Configuration c = HBaseConfiguration.create(); @@ -42,6 +42,5 @@ public class TestZooKeeperMainServerArg { assertTrue(port, parser.parse(c).matches("(example[1-3]\\.com,){2}example[1-3]\\.com:" + port)); } - }