From 55af050abe89b4d0f80ef3bc68a1dd010267fe95 Mon Sep 17 00:00:00 2001 From: Jean-Daniel Cryans Date: Wed, 3 Nov 2010 23:42:18 +0000 Subject: [PATCH] HBASE-2471 Splitting logs, we'll make an output file though the region no longer exists git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1030760 13f79535-47bb-0310-9956-ffa450edef68 --- CHANGES.txt | 2 + .../hbase/regionserver/wal/HLogSplitter.java | 10 ++++ .../hbase/regionserver/wal/TestHLog.java | 9 ++- .../hbase/regionserver/wal/TestHLogSplit.java | 55 ++++++++++++++++--- .../hbase/regionserver/wal/TestWALReplay.java | 2 + 5 files changed, 67 insertions(+), 11 deletions(-) diff --git a/CHANGES.txt b/CHANGES.txt index 442f71e2a5e..92b917e3e81 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -645,6 +645,8 @@ Release 0.21.0 - Unreleased HBASE-3151 NPE when trying to read regioninfo from .META. HBASE-3191 FilterList with MUST_PASS_ONE and SCVF isn't working (Stefan Seelmann via Stack) + HBASE-2471 Splitting logs, we'll make an output file though the + region no longer exists IMPROVEMENTS diff --git a/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java b/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java index fe4bfb1ea06..ad104e16a05 100644 --- a/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java +++ b/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java @@ -430,6 +430,12 @@ public class HLogSplitter { .getTablename()); Path regiondir = HRegion.getRegionDir(tableDir, Bytes.toString(logEntry.getKey().getEncodedRegionName())); + if (!fs.exists(regiondir)) { + LOG.info("This region's directory doesn't exist: " + + regiondir.toString() + ". It is very likely that it was" + + " already split so it's safe to discard those edits."); + return null; + } Path dir = HLog.getRegionDirRecoveredEditsDir(regiondir); if (!fs.exists(dir)) { if (!fs.mkdirs(dir)) LOG.warn("mkdir failed on " + dir); @@ -526,6 +532,10 @@ public class HLogSplitter { for (Entry logEntry : entries) { if (wap == null) { Path regionedits = getRegionSplitEditsPath(fs, logEntry, rootDir); + if (regionedits == null) { + // we already print a message if it's null in getRegionSplitEditsPath + break; + } if (fs.exists(regionedits)) { LOG.warn("Found existing old edits file. It could be the " + "result of a previous failed split attempt. Deleting " diff --git a/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java b/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java index 7077f45162e..c35048b1f04 100644 --- a/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java +++ b/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java @@ -132,13 +132,17 @@ public class TestHLog { final byte [] tableName = Bytes.toBytes(getName()); final byte [] rowName = tableName; - Path logdir = new Path(dir, HConstants.HREGION_LOGDIR_NAME); + Path logdir = new Path(hbaseDir, HConstants.HREGION_LOGDIR_NAME); HLog log = new HLog(fs, logdir, oldLogDir, conf); final int howmany = 3; HRegionInfo[] infos = new HRegionInfo[3]; + Path tabledir = new Path(hbaseDir, getName()); + fs.mkdirs(tabledir); for(int i = 0; i < howmany; i++) { infos[i] = new HRegionInfo(new HTableDescriptor(tableName), Bytes.toBytes("" + i), Bytes.toBytes("" + (i+1)), false); + fs.mkdirs(new Path(tabledir, infos[i].getEncodedName())); + LOG.info("allo " + new Path(tabledir, infos[i].getEncodedName()).toString()); } // Add edits for three regions. try { @@ -160,10 +164,9 @@ public class TestHLog { log.rollWriter(); } log.close(); - Path splitsdir = new Path(this.dir, "splits"); HLogSplitter logSplitter = HLogSplitter.createLogSplitter(conf); List splits = - logSplitter.splitLog(splitsdir, logdir, + logSplitter.splitLog(hbaseDir, logdir, this.oldLogDir, this.fs, conf); verifySplits(splits, howmany); log = null; diff --git a/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLogSplit.java b/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLogSplit.java index 473c3595f81..9fc31781795 100644 --- a/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLogSplit.java +++ b/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLogSplit.java @@ -20,6 +20,7 @@ package org.apache.hadoop.hbase.regionserver.wal; import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertFalse; import static org.junit.Assert.assertNull; import static org.junit.Assert.assertTrue; @@ -31,6 +32,8 @@ import java.util.List; import java.util.concurrent.atomic.AtomicBoolean; import java.util.concurrent.atomic.AtomicLong; +import org.apache.commons.logging.Log; +import org.apache.commons.logging.LogFactory; import org.apache.hadoop.conf.Configuration; import org.apache.hadoop.fs.FSDataInputStream; import org.apache.hadoop.fs.FSDataOutputStream; @@ -57,6 +60,8 @@ import org.junit.Test; */ public class TestHLogSplit { + private final static Log LOG = LogFactory.getLog(TestHLogSplit.class); + private Configuration conf; private FileSystem fs; @@ -81,7 +86,8 @@ public class TestHLogSplit { private static final String HLOG_FILE_PREFIX = "hlog.dat."; private static List regions; private static final String HBASE_SKIP_ERRORS = "hbase.hlog.split.skip.errors"; - + private static final Path tabledir = + new Path(hbaseDir, Bytes.toString(TABLE_NAME)); static enum Corruptions { INSERT_GARBAGE_ON_FIRST_LINE, @@ -137,11 +143,15 @@ public class TestHLogSplit { @Test public void testRecoveredEditsPathForMeta() throws IOException { FileSystem fs = FileSystem.get(TEST_UTIL.getConfiguration()); byte [] encoded = HRegionInfo.FIRST_META_REGIONINFO.getEncodedNameAsBytes(); + Path tdir = new Path(hbaseDir, Bytes.toString(HConstants.META_TABLE_NAME)); + Path regiondir = new Path(tdir, + HRegionInfo.FIRST_META_REGIONINFO.getEncodedName()); + fs.mkdirs(regiondir); long now = System.currentTimeMillis(); HLog.Entry entry = new HLog.Entry(new HLogKey(encoded, HConstants.META_TABLE_NAME, 1, now), new WALEdit()); - Path p = HLogSplitter.getRegionSplitEditsPath(fs, entry, new Path("/")); + Path p = HLogSplitter.getRegionSplitEditsPath(fs, entry, hbaseDir); String parentOfParent = p.getParent().getParent().getName(); assertEquals(parentOfParent, HRegionInfo.FIRST_META_REGIONINFO.getEncodedName()); } @@ -498,10 +508,14 @@ public class TestHLogSplit { fs.initialize(fs.getUri(), conf); - InstrumentedSequenceFileLogWriter.activateFailure = false; - appendEntry(writer[4], TABLE_NAME, Bytes.toBytes("break"), ("r" + 999).getBytes(), FAMILY, QUALIFIER, VALUE, 0); - writer[4].close(); + String region = "break"; + Path regiondir = new Path(tabledir, region); + fs.mkdirs(regiondir); + InstrumentedSequenceFileLogWriter.activateFailure = false; + appendEntry(writer[4], TABLE_NAME, Bytes.toBytes(region), + ("r" + 999).getBytes(), FAMILY, QUALIFIER, VALUE, 0); + writer[4].close(); try { InstrumentedSequenceFileLogWriter.activateFailure = true; @@ -543,6 +557,25 @@ public class TestHLogSplit { assertEquals(0, compareHLogSplitDirs(firstSplitPath, splitPath)); } + @Test + public void testSplitDeletedRegion() throws IOException { + regions.removeAll(regions); + String region = "region_that_splits"; + regions.add(region); + + generateHLogs(1); + + fs.initialize(fs.getUri(), conf); + + Path regiondir = new Path(tabledir, region); + fs.delete(regiondir, true); + + HLogSplitter logSplitter = HLogSplitter.createLogSplitter(conf); + logSplitter.splitLog(hbaseDir, hlogDir, oldLogDir, fs, conf); + + assertFalse(fs.exists(regiondir)); + } + /** * This thread will keep writing to the file after the split process has started * It simulates a region server that was considered dead but woke up and wrote @@ -567,8 +600,10 @@ public class TestHLogSplit { flushToConsole("starting"); while (true) { try { - - appendEntry(lastLogWriter, TABLE_NAME, "juliet".getBytes(), + String region = "juliet"; + + fs.mkdirs(new Path(new Path(hbaseDir, region), region)); + appendEntry(lastLogWriter, TABLE_NAME, region.getBytes(), ("r" + editsCount).getBytes(), FAMILY, QUALIFIER, VALUE, 0); lastLogWriter.sync(); editsCount.incrementAndGet(); @@ -631,9 +666,10 @@ public class TestHLogSplit { flushToConsole("Juliet: split not started, sleeping a bit..."); Threads.sleep(100); } - + String region = "juliet"; Path julietLog = new Path(hlogDir, HLOG_FILE_PREFIX + ".juliet"); try { + fs.mkdirs(new Path(new Path(hbaseDir, region), region)); HLog.Writer writer = HLog.createWriter(fs, julietLog, conf); appendEntry(writer, "juliet".getBytes(), ("juliet").getBytes(), @@ -657,6 +693,9 @@ public class TestHLogSplit { } private void generateHLogs(int writers, int entries, int leaveOpen) throws IOException { + for (String region : regions) { + fs.mkdirs(new Path(tabledir, region)); + } for (int i = 0; i < writers; i++) { writer[i] = HLog.createWriter(fs, new Path(hlogDir, HLOG_FILE_PREFIX + i), conf); for (int j = 0; j < entries; j++) { diff --git a/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestWALReplay.java b/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestWALReplay.java index dc55407bcf9..b9902f17787 100644 --- a/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestWALReplay.java +++ b/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestWALReplay.java @@ -128,6 +128,7 @@ public class TestWALReplay { HRegionInfo hri = createBasic3FamilyHRegionInfo(tableNameStr); Path basedir = new Path(hbaseRootDir, tableNameStr); deleteDir(basedir); + fs.mkdirs(new Path(basedir, hri.getEncodedName())); final byte [] tableName = Bytes.toBytes(tableNameStr); final byte [] rowName = tableName; @@ -325,6 +326,7 @@ public class TestWALReplay { HRegionInfo hri = createBasic3FamilyHRegionInfo(tableNameStr); Path basedir = new Path(hbaseRootDir, tableNameStr); deleteDir(basedir); + fs.mkdirs(new Path(basedir, hri.getEncodedName())); HLog wal = createWAL(this.conf); final byte[] tableName = Bytes.toBytes(tableNameStr); final byte[] rowName = tableName;