HBASE-16816 HMaster.move() should throw exception if region to move is not online (Allan Yang)

hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java

@@ -1501,6 +1501,11 @@ public class HMaster extends HRegionServer implements MasterServices, Server {
       getRegionState(Bytes.toString(encodedRegionName));
     if (regionState == null) {
       throw new UnknownRegionException(Bytes.toStringBinary(encodedRegionName));
+    } else if (!assignmentManager.getRegionStates()
+        .isRegionOnline(regionState.getRegion())) {
+      throw new HBaseIOException(
+          "moving region not onlined: " + regionState.getRegion() + ", "
+              + regionState);
     }
 
     HRegionInfo hri = regionState.getRegion();

hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestWarmupRegion.java

@@ -157,6 +157,8 @@ public class TestWarmupRegion {
        HRegionServer rs = TEST_UTIL.getMiniHBaseCluster().getRegionServer(serverid);
        byte [] destName = Bytes.toBytes(rs.getServerName().toString());
        TEST_UTIL.getMiniHBaseCluster().getMaster().move(info.getEncodedNameAsBytes(), destName);
+       //wait region online
+       TEST_UTIL.waitUntilNoRegionsInTransition(1000);
        serverid = (serverid + 1) % 2;
      }
    }