Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-10481 API Compatibility JDiff script does not properly handle arguments in reverse order (Aleksandr Shulman) 

git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1567471 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Michael Stack 2014-02-11 23:59:20 +00:00
parent b6d4bea6fd
commit 5938f5ad16
1 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
dev-support/jdiffHBasePublicAPI.sh
View File

@ -67,6 +67,11 @@ set -e
# > ./jdiffHBasePublicAPI.sh /home/aleks/stable_hbase/hbase stable_95 /home/aleks/exp_hbase/hbase experiment_95 # > ./jdiffHBasePublicAPI.sh /home/aleks/stable_hbase/hbase stable_95 /home/aleks/exp_hbase/hbase experiment_95
# #
# #
################################################## NOTE ON USAGE ###################################################
#
# 1. When using this tool, please specify the initial version first and the current version second. The semantics
# do not make sense otherwise. For example: jdiff 94 95 is good. jdiff 95 94 is bad
#
############################################# READING A JDIFF REPORT ############################################### ############################################# READING A JDIFF REPORT ###############################################
# #
# The purpose of the JDiff report is show things that have changed between two versions of the public API. A user # The purpose of the JDiff report is show things that have changed between two versions of the public API. A user
@ -131,8 +136,8 @@ fi
#If the JDIFF_WORKING_DIRECTORY is set, then we will output the report there. Otherwise, to the default location #If the JDIFF_WORKING_DIRECTORY is set, then we will output the report there. Otherwise, to the default location
if [[ "$JDIFF_WORKING_DIRECTORY" = "" ]]; then if [[ "$JDIFF_WORKING_DIRECTORY" = "" ]]; then
echo "JDIFF_WORKING_DIRECTORY not set. That's not an issue. We will default it to ./jidff"
JDIFF_WORKING_DIRECTORY=/tmp/jdiff JDIFF_WORKING_DIRECTORY=/tmp/jdiff
echo "JDIFF_WORKING_DIRECTORY not set. That's not an issue. We will default it to $JDIFF_WORKING_DIRECTORY."
else else
echo "JDIFF_WORKING_DIRECTORY set to $JDIFF_WORKING_DIRECTORY"; echo "JDIFF_WORKING_DIRECTORY set to $JDIFF_WORKING_DIRECTORY";
fi fi
@ -204,6 +209,13 @@ if [[ "$C_FORMAT" = "new" ]]; then
fi fi
else else
if [[ "P_FORMAT" != "old" ]]; then
echo "When using this tool, please specify the initial version first and the current version second. They should be in ascending chronological order.
The semantics do not make sense otherwise. For example: jdiff 94 95 is good. jdiff 95 94 is bad."
echo "Exiting the script."
exit 5;
fi
templateFile=$DEV_SUPPORT_HOME/hbase_jdiff_template.xml templateFile=$DEV_SUPPORT_HOME/hbase_jdiff_template.xml
echo "Both formats are using the 94 and earlier style directory format. We'll be using template $templateFile" echo "Both formats are using the 94 and earlier style directory format. We'll be using template $templateFile"
fi fi