Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-7586 Fix two findbugs warnings to get our count down to the tolerated number again 

git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1434365 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Michael Stack 2013-01-16 20:25:23 +00:00
parent ee766c07f9
commit 5c8c3d0a8c
2 changed files with 8 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
hbase-server/src/main/java/org/apache/hadoop/hbase/client/ClientScanner.java
View File

@ -69,8 +69,8 @@ public class ClientScanner extends AbstractClientScanner {
/**
* Create a new ClientScanner for the specified table. An HConnection will be
* retrieved using the passed Configuration.
* Note that the passed {@link Scan}'s start row maybe changed changed.
*
* Note that the passed {@link Scan}'s start row maybe changed changed.
*
* @param conf The {@link Configuration} to use.
* @param scan {@link Scan} to use in this scanner
* @param tableName The table that we wish to scan
@ -80,11 +80,11 @@ public class ClientScanner extends AbstractClientScanner {
final byte[] tableName) throws IOException {
this(conf, scan, tableName, HConnectionManager.getConnection(conf));
}
/**
* Create a new ClientScanner for the specified table
* Note that the passed {@link Scan}'s start row maybe changed changed.
*
* Note that the passed {@link Scan}'s start row maybe changed changed.
*
* @param conf The {@link Configuration} to use.
* @param scan {@link Scan} to use in this scanner
* @param tableName The table that we wish to scan
@ -250,7 +250,6 @@ public class ClientScanner extends AbstractClientScanner {
if (this.scanMetrics == null) {
return;
}
final DataOutputBuffer d = new DataOutputBuffer();
MapReduceProtos.ScanMetrics pScanMetrics = ProtobufUtil.toScanMetrics(scanMetrics);
scan.setAttribute(Scan.SCAN_ATTRIBUTES_METRICS_DATA, pScanMetrics.toByteArray());
}

6
hbase-server/src/main/java/org/apache/hadoop/hbase/filter/FirstKeyOnlyFilter.java
View File

@ -90,13 +90,13 @@ public class FirstKeyOnlyFilter extends FilterBase {
*/
public static FirstKeyOnlyFilter parseFrom(final byte [] pbBytes)
throws DeserializationException {
FilterProtos.FirstKeyOnlyFilter proto;
// There is nothing to deserialize. Why do this at all?
try {
proto = FilterProtos.FirstKeyOnlyFilter.parseFrom(pbBytes);
FilterProtos.FirstKeyOnlyFilter.parseFrom(pbBytes);
} catch (InvalidProtocolBufferException e) {
throw new DeserializationException(e);
}
// Just return a new instance.
return new FirstKeyOnlyFilter();
}