Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-19484 The value array written by ExtendedCell#write is out of bounds

This commit is contained in:
Chia-Ping Tsai 2017-12-11 09:10:14 +08:00
parent e444f549d7
commit 6010daf8b0
2 changed files with 21 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hbase-common/src/main/java/org/apache/hadoop/hbase/ExtendedCell.java
View File

@ -54,7 +54,7 @@ public interface ExtendedCell extends RawCell, HeapSize, Cloneable {
PrivateCellUtil.writeFlatKey(this, out);
// Value
out.write(getValueArray());
out.write(getValueArray(), getValueOffset(), getValueLength());
// Tags length and tags byte array
if (withTags && getTagsLength() > 0) {

20
hbase-common/src/test/java/org/apache/hadoop/hbase/TestIndividualBytesFieldCell.java
View File

@ -252,4 +252,24 @@ public class TestIndividualBytesFieldCell {
assertEquals(cell.getSerializedSize(true), buf.length);
}
}
@Test
public void testWriteValue() throws IOException {
byte[] value = Bytes.toBytes("---value---");
int valueOffset = 3;
int valueLength = 5;
IndividualBytesFieldCell cell
= new IndividualBytesFieldCell(Bytes.toBytes("row"), 0, 3,
Bytes.toBytes("family"), 0, 6,
Bytes.toBytes("qualifier"), 0, 9,
0L, KeyValue.Type.Put, 0,
value, valueOffset, valueLength,
Bytes.toBytes("value"), 0, 5);
try (ByteArrayOutputStream output = new ByteArrayOutputStream(300)) {
cell.write(output, true);
byte[] buf = output.toByteArray();
assertEquals(cell.getSerializedSize(true), buf.length);
}
}
}