Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-21712 : Make submit-patch.py python3 compatible 

Signed-off-by: Sergey Shelukhin <sershe@apache.org>
This commit is contained in:
Tommy Li 2019-01-14 14:29:52 -08:00 committed by Sergey Shelukhin
parent 7795af0057
commit 63a1fcbe46
2 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
.pylintrc
View File

@ -133,6 +133,9 @@ dummy-variables-rgx=_|dummy
# you should avoid to define new builtins when possible. # you should avoid to define new builtins when possible.
additional-builtins= additional-builtins=
# List of modules that can redefine builtins. (For python 2/3 compatibility)
redefining-builtins-modules=builtins
[TYPECHECK] [TYPECHECK]

7
dev-support/submit-patch.py
View File

@ -22,6 +22,7 @@
# are not updated. Review board id is retrieved from the remote link in the jira. # are not updated. Review board id is retrieved from the remote link in the jira.
# Print help: submit-patch.py --h # Print help: submit-patch.py --h
import argparse import argparse
from builtins import input, str
import getpass import getpass
import git import git
import json import json
@ -146,7 +147,7 @@ def get_patch_name_with_version(patch_name_prefix):
if html.status_code != 200: if html.status_code != 200:
log_fatal_and_exit(" Cannot fetch jira information. Status code %s", html.status_code) log_fatal_and_exit(" Cannot fetch jira information. Status code %s", html.status_code)
# Iterate over patch names starting from version 1 and return when name is not already used. # Iterate over patch names starting from version 1 and return when name is not already used.
content = unicode(html.content, 'utf-8') content = str(html.content, 'utf-8')
for i in range(1, 1000): for i in range(1, 1000):
name = patch_name_prefix + "." + ('{0:03d}'.format(i)) + ".patch" name = patch_name_prefix + "." + ('{0:03d}'.format(i)) + ".patch"
if name not in content: if name not in content:
@ -196,10 +197,10 @@ def get_credentials():
log_fatal_and_exit(" Couldn't decrypt ~/.apache-creds file. Exiting..") log_fatal_and_exit(" Couldn't decrypt ~/.apache-creds file. Exiting..")
creds = json.loads(content) creds = json.loads(content)
else: else:
creds['jira_username'] = raw_input("Jira username:") creds['jira_username'] = input("Jira username:")
creds['jira_password'] = getpass.getpass("Jira password:") creds['jira_password'] = getpass.getpass("Jira password:")
if not args.skip_review_board: if not args.skip_review_board:
creds['rb_username'] = raw_input("Review Board username:") creds['rb_username'] = input("Review Board username:")
creds['rb_password'] = getpass.getpass("Review Board password:") creds['rb_password'] = getpass.getpass("Review Board password:")
return creds return creds