HBASE-19987 error-prone 2.2.0

hbase-build-support/hbase-error-prone/pom.xml

@@ -37,6 +37,12 @@
       <artifactId>error_prone_annotation</artifactId>
       <version>${error-prone.version}</version>
       <scope>provided</scope>
+      <exclusions>
+        <exclusion>
+          <groupId>com.google.guava</groupId>
+          <artifactId>guava</artifactId>
+        </exclusion>
+      </exclusions>
     </dependency>
     <dependency>
       <!--mvn dependency:analyze says this is not used but compile fails

hbase-build-support/hbase-error-prone/src/main/java/org/apache/hadoop/hbase/errorprone/AlwaysPasses.java

@@ -30,7 +30,7 @@ import com.sun.source.tree.CompilationUnitTree;
     category = BugPattern.Category.JDK,
     summary = "A placeholder rule that never matches.",
     severity = BugPattern.SeverityLevel.ERROR,
-    suppressibility = BugPattern.Suppressibility.UNSUPPRESSIBLE,
+    suppressionAnnotations = {},
     linkType = BugPattern.LinkType.NONE)
 public class AlwaysPasses extends BugChecker implements BugChecker.CompilationUnitTreeMatcher {
   @Override

hbase-client/src/main/java/org/apache/hadoop/hbase/ServerLoad.java

@@ -448,7 +448,7 @@ public class ServerLoad implements ServerMetrics {
         .collect(Collectors.toMap(Map.Entry::getKey, e -> new RegionLoad(e.getValue()),
           (v1, v2) -> {
             throw new RuntimeException("key collisions?");
-          }, () -> new TreeMap(Bytes.BYTES_COMPARATOR)));
+          }, () -> new TreeMap<>(Bytes.BYTES_COMPARATOR)));
   }
 
   /**

hbase-client/src/main/java/org/apache/hadoop/hbase/client/Mutation.java

@@ -118,7 +118,7 @@ public abstract class Mutation extends OperationWithAttributes implements Row, C
       .collect(Collectors.toMap(e -> e.getKey(), e -> new ArrayList<>(e.getValue()),
         (k, v) -> {
           throw new RuntimeException("collisions!!!");
-        }, () -> new TreeMap(Bytes.BYTES_COMPARATOR)));
+        }, () -> new TreeMap<>(Bytes.BYTES_COMPARATOR)));
   }
 
   /**

hbase-client/src/main/java/org/apache/hadoop/hbase/filter/BigDecimalComparator.java

@@ -36,6 +36,7 @@ import org.apache.yetus.audience.InterfaceAudience;
  * A BigDecimal comparator which numerical compares against the specified byte array
  */
 @InterfaceAudience.Public
+@SuppressWarnings("ComparableType") // Should this move to Comparator usage?
 public class BigDecimalComparator extends ByteArrayComparable {
   private BigDecimal bigDecimal;
 

hbase-client/src/main/java/org/apache/hadoop/hbase/filter/BinaryComparator.java

@@ -36,6 +36,7 @@ import org.apache.hbase.thirdparty.com.google.protobuf.InvalidProtocolBufferExce
  * @since 2.0.0
  */
 @InterfaceAudience.Public
+@SuppressWarnings("ComparableType") // Should this move to Comparator usage?
 public class BinaryComparator extends org.apache.hadoop.hbase.filter.ByteArrayComparable {
   /**
    * Constructor

hbase-client/src/main/java/org/apache/hadoop/hbase/filter/BinaryPrefixComparator.java

@@ -36,6 +36,7 @@ import org.apache.hbase.thirdparty.com.google.protobuf.InvalidProtocolBufferExce
  * {@link BinaryComparator}.
  */
 @InterfaceAudience.Public
+@SuppressWarnings("ComparableType") // Should this move to Comparator usage?
 public class BinaryPrefixComparator extends ByteArrayComparable {
 
   /**

hbase-client/src/main/java/org/apache/hadoop/hbase/filter/BitComparator.java

@@ -33,6 +33,7 @@ import org.apache.hbase.thirdparty.com.google.protobuf.InvalidProtocolBufferExce
  * with the specified byte array. Then returns whether the result is non-zero.
  */
 @InterfaceAudience.Public
+@SuppressWarnings("ComparableType") // Should this move to Comparator usage?
 public class BitComparator extends ByteArrayComparable {
 
   /** Bit operators. */

hbase-client/src/main/java/org/apache/hadoop/hbase/filter/LongComparator.java

@@ -34,6 +34,7 @@ import org.apache.hadoop.hbase.util.Bytes;
  * A long comparator which numerical compares against the specified byte array
  */
 @InterfaceAudience.Public
+@SuppressWarnings("ComparableType") // Should this move to Comparator usage?
 public class LongComparator extends ByteArrayComparable {
   private long longValue;
 

hbase-client/src/main/java/org/apache/hadoop/hbase/filter/NullComparator.java

@@ -32,6 +32,7 @@ import org.apache.hbase.thirdparty.com.google.protobuf.InvalidProtocolBufferExce
  * byte array using {@link org.apache.hadoop.hbase.util.Bytes#compareTo(byte[], byte[])}.
  */
 @InterfaceAudience.Public
+@SuppressWarnings("ComparableType") // Should this move to Comparator usage?
 public class NullComparator extends ByteArrayComparable {
 
   public NullComparator() {

hbase-client/src/main/java/org/apache/hadoop/hbase/filter/RegexStringComparator.java

@@ -69,6 +69,7 @@ import org.apache.hbase.thirdparty.com.google.protobuf.InvalidProtocolBufferExce
  * @see java.util.regex.Pattern
  */
 @InterfaceAudience.Public
+@SuppressWarnings("ComparableType") // Should this move to Comparator usage?
 public class RegexStringComparator extends ByteArrayComparable {
 
   private static final Logger LOG = LoggerFactory.getLogger(RegexStringComparator.class);

hbase-client/src/main/java/org/apache/hadoop/hbase/filter/SubstringComparator.java

@@ -43,6 +43,7 @@ import org.apache.hbase.thirdparty.com.google.protobuf.InvalidProtocolBufferExce
  * </pre>
  */
 @InterfaceAudience.Public
+@SuppressWarnings("ComparableType") // Should this move to Comparator usage?
 public class SubstringComparator extends ByteArrayComparable {
 
   private String substr;

hbase-common/src/main/java/org/apache/hadoop/hbase/filter/ByteArrayComparable.java

@@ -32,6 +32,7 @@ import org.apache.yetus.audience.InterfaceAudience;
 // adding special compareTo methods. We have to clean it. Deprecate this class and replace it
 // with a more generic one which says it compares bytes (not necessary a byte array only)
 // BytesComparable implements Comparable<Byte> will work?
+@SuppressWarnings("ComparableType") // Should this move to Comparator usage?
 public abstract class ByteArrayComparable implements Comparable<byte[]> {
 
   byte[] value;

pom.xml

@@ -1464,7 +1464,7 @@
     <buildnumber.maven.version>1.4</buildnumber.maven.version>
     <checkstyle.version>6.18</checkstyle.version>
     <exec.maven.version>1.6.0</exec.maven.version>
-    <error-prone.version>2.1.1</error-prone.version>
+    <error-prone.version>2.2.0</error-prone.version>
     <findbugs-annotations>1.3.9-1</findbugs-annotations>
     <findbugs.maven.version>3.0.4</findbugs.maven.version>
     <jamon.plugin.version>2.4.2</jamon.plugin.version>