Apache/hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-13342 Fix incorrect interface annotations

Browse Source
This commit is contained in:
Elliott Clark 2015-03-26 11:48:19 -07:00
parent 66af9410b1
commit 650c9f27fd
3 changed files with 27 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
dev-support/test-patch.sh
View File

@ -420,6 +420,29 @@ checkAntiPatterns () {
return 0 return 0
} }
###############################################################################
### Check that there are no incorrect annotations
checkInterfaceAudience () {
echo ""
echo ""
echo "======================================================================"
echo "======================================================================"
echo " Checking against hadoop InterfaceAudience."
echo "======================================================================"
echo "======================================================================"
echo ""
echo ""
warnings=`$GREP 'import org.apache.hadoop.classification' $PATCH_DIR/patch`
if [[ $warnings != "" ]]; then
JIRA_COMMENT="$JIRA_COMMENT
{color:red}-1 InterfaceAudience{color}. The patch appears to contain InterfaceAudience from hadoop rather than hbase:
$warnings."
return 1
fi
return 0
}
############################################################################### ###############################################################################
### Check there are no javadoc warnings ### Check there are no javadoc warnings
checkJavadocWarnings () { checkJavadocWarnings () {
@ -909,6 +932,8 @@ checkJavadocWarnings
(( RESULT = RESULT + $? )) (( RESULT = RESULT + $? ))
checkCheckstyleErrors checkCheckstyleErrors
(( RESULT = RESULT + $? )) (( RESULT = RESULT + $? ))
checkInterfaceAudience
(( RESULT = RESULT + $? ))
checkFindbugsWarnings checkFindbugsWarnings
(( RESULT = RESULT + $? )) (( RESULT = RESULT + $? ))
checkReleaseAuditWarnings checkReleaseAuditWarnings

2
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/handler/RegionReplicaFlushHandler.java
View File

@ -23,11 +23,11 @@ import java.io.InterruptedIOException;
import org.apache.commons.logging.Log; import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory; import org.apache.commons.logging.LogFactory;
import org.apache.hadoop.classification.InterfaceAudience;
import org.apache.hadoop.conf.Configuration; import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.hbase.HConstants; import org.apache.hadoop.hbase.HConstants;
import org.apache.hadoop.hbase.Server; import org.apache.hadoop.hbase.Server;
import org.apache.hadoop.hbase.TableNotFoundException; import org.apache.hadoop.hbase.TableNotFoundException;
import org.apache.hadoop.hbase.classification.InterfaceAudience;
import org.apache.hadoop.hbase.client.ClusterConnection; import org.apache.hadoop.hbase.client.ClusterConnection;
import org.apache.hadoop.hbase.client.FlushRegionCallable; import org.apache.hadoop.hbase.client.FlushRegionCallable;
import org.apache.hadoop.hbase.client.RegionReplicaUtil; import org.apache.hadoop.hbase.client.RegionReplicaUtil;

2
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ReplayHLogKey.java
View File

@ -22,8 +22,8 @@ import java.io.IOException;
import java.util.List; import java.util.List;
import java.util.UUID; import java.util.UUID;
import org.apache.hadoop.classification.InterfaceAudience;
import org.apache.hadoop.hbase.TableName; import org.apache.hadoop.hbase.TableName;
import org.apache.hadoop.hbase.classification.InterfaceAudience;
/** /**
* An HLogKey specific to WalEdits coming from replay. * An HLogKey specific to WalEdits coming from replay.