Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-11009 We sync every hbase:meta table write twice 

git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1588329 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Michael Stack 2014-04-17 18:12:28 +00:00
parent 2c5f834a51
commit 6c643e2031
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java
View File

@ -1125,7 +1125,7 @@ class FSHLog implements HLog, Syncable {
* @param clusterIds that have consumed the change (for replication) * @param clusterIds that have consumed the change (for replication)
* @param now * @param now
* @param htd * @param htd
* @param doSync shall we sync? * @param doSync shall we sync after we call the append?
* @param inMemstore * @param inMemstore
* @param sequenceId of the region. * @param sequenceId of the region.
* @param nonceGroup * @param nonceGroup
@ -1158,11 +1158,13 @@ class FSHLog implements HLog, Syncable {
} finally { } finally {
this.disruptor.getRingBuffer().publish(sequence); this.disruptor.getRingBuffer().publish(sequence);
} }
// Sync if we have been asked to -- only tests do this -- or if it is a meta table edit (these // doSync is set in tests. Usually we arrive in here via appendNoSync w/ the sync called after
// are precious). When we sync, we will sync to the current point, the txid of the last edit // all edits on a handler have been added.
// added. Since we are single writer, the next txid should be the just next one in sequence; //
// do not explicitly specify it (sequence id/txid is an implementation internal detail. // When we sync, we will sync to the current point, the txid of the last edit added.
if (doSync || info.isMetaRegion()) publishSyncThenBlockOnCompletion(); // Since we are single writer, the next txid should be the just next one in sequence;
// do not explicitly specify it. Sequence id/txid is an implementation internal detail.
if (doSync) publishSyncThenBlockOnCompletion();
return sequence; return sequence;
} }