HBASE-12355 Update maven plugins

Conflicts:
	hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/QuotaCache.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java

hbase-checkstyle/pom.xml

@@ -52,6 +52,7 @@
       </configuration>
     </plugin>
     <plugin>
+      <groupId>org.apache.maven.plugins</groupId>
       <artifactId>maven-surefire-plugin</artifactId>
       <executions>
         <execution>

hbase-server/src/main/java/org/apache/hadoop/hbase/JMXListener.java

@@ -51,7 +51,7 @@ public class JMXListener implements Coprocessor {
   public static final Log LOG = LogFactory.getLog(JMXListener.class);
   public static final String RMI_REGISTRY_PORT_CONF_KEY = ".rmi.registry.port";
   public static final String RMI_CONNECTOR_PORT_CONF_KEY = ".rmi.connector.port";
-  public static int defRMIRegistryPort = 10102;
+  public static final int defRMIRegistryPort = 10102;
 
   /**
    * workaround for HBASE-11146

hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/ZKSplitLogManagerCoordination.java

@@ -98,8 +98,6 @@ public class ZKSplitLogManagerCoordination extends ZooKeeperListener implements
 
   SplitLogManagerDetails details;
 
-  private final Stoppable stopper = null;
-
   // When lastRecoveringNodeCreationTime is older than the following threshold, we'll check
   // whether to GC stale recovering znodes
   private volatile long lastRecoveringNodeCreationTime = 0;
@@ -669,7 +667,7 @@ public class ZKSplitLogManagerCoordination extends ZooKeeperListener implements
         } catch (InterruptedException e) {
           throw new InterruptedIOException();
         }
-      } while ((--retries) > 0 && (!this.stopper.isStopped()));
+      } while ((--retries) > 0);
     }
   }
 

hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java

@@ -146,7 +146,7 @@ import com.google.protobuf.TextFormat;
  * and keep taking while the server is up.
  *
  * CallRunner#run executes the call.  When done, asks the included Call to put itself on new
- * queue for {@link Responder} to pull from and return result to client.
+ * queue for Responder to pull from and return result to client.
  *
  * @see RpcClient
  */

hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/BaseLoadBalancer.java

@@ -524,7 +524,7 @@ public abstract class BaseLoadBalancer implements LoadBalancer {
 
     @edu.umd.cs.findbugs.annotations.SuppressWarnings(value="NM_FIELD_NAMING_CONVENTION",
         justification="Mistake. Too disruptive to change now")
-    public static Action NullAction = new Action(Type.NULL);
+    public static final Action NullAction = new Action(Type.NULL);
 
     public void doAction(Action action) {
       switch (action.type) {

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DelimitedKeyPrefixRegionSplitPolicy.java

@@ -50,21 +50,15 @@ public class DelimitedKeyPrefixRegionSplitPolicy extends IncreasingToUpperBoundR
   @Override
   protected void configureForRegion(HRegion region) {
     super.configureForRegion(region);
-    if (region != null) {
-
     // read the prefix length from the table descriptor
-      String delimiterString = region.getTableDesc().getValue(
+    String delimiterString = region.getTableDesc().getValue(DELIMITER_KEY);
-          DELIMITER_KEY);
     if (delimiterString == null || delimiterString.length() == 0) {
-        LOG.error(DELIMITER_KEY + " not specified for table "
+      LOG.error(DELIMITER_KEY + " not specified for table " + region.getTableDesc().getTableName() +
-            + region.getTableDesc().getTableName()
+        ". Using default RegionSplitPolicy");
-            + ". Using default RegionSplitPolicy");
       return;
     }
-
     delimiter = Bytes.toBytes(delimiterString);
   }
-  }
 
   @Override
   protected byte[] getSplitPoint() {

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/KeyPrefixRegionSplitPolicy.java

@@ -43,7 +43,6 @@ public class KeyPrefixRegionSplitPolicy extends IncreasingToUpperBoundRegionSpli
   @Override
   protected void configureForRegion(HRegion region) {
     super.configureForRegion(region);
-    if (region != null) {
     prefixLength = 0;
 
     // read the prefix length from the table descriptor
@@ -74,7 +73,6 @@ public class KeyPrefixRegionSplitPolicy extends IncreasingToUpperBoundRegionSpli
           + prefixLengthString + ". Using default RegionSplitPolicy");
     }
   }
-  }
 
   @Override
   protected byte[] getSplitPoint() {

hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java

@@ -1286,7 +1286,7 @@ public class AccessController extends BaseMasterAndRegionObserver
             ourFilter = new FilterList(FilterList.Operator.MUST_PASS_ALL,
               Lists.newArrayList(ourFilter, filter));
           }
-          authResult.setAllowed(true);;
+          authResult.setAllowed(true);
           authResult.setReason("Access allowed with filter");
           switch (opType) {
           case GET:
@@ -1312,7 +1312,7 @@ public class AccessController extends BaseMasterAndRegionObserver
           ourFilter = new FilterList(FilterList.Operator.MUST_PASS_ALL,
             Lists.newArrayList(ourFilter, filter));
         }
-        authResult.setAllowed(true);;
+        authResult.setAllowed(true);
         authResult.setReason("Access allowed with filter");
         switch (opType) {
         case GET:

hbase-server/src/main/java/org/apache/hadoop/hbase/util/CompressionTest.java

@@ -127,7 +127,7 @@ public class CompressionTest {
     // Write any-old Cell...
     final byte [] rowKey = Bytes.toBytes("compressiontestkey");
     Cell c = CellUtil.createCell(rowKey, Bytes.toBytes("compressiontestval"));
-    writer.append(c);;
+    writer.append(c);
     writer.appendFileInfo(Bytes.toBytes("compressioninfokey"), Bytes.toBytes("compressioninfoval"));
     writer.close();
     Cell cc = null;

hbase-server/src/main/java/org/apache/hadoop/hbase/util/MultiHConnection.java

@@ -76,7 +76,6 @@ public class MultiHConnection {
    */
   public void close() {
     synchronized (hConnectionsLock) {
-      if (hConnections != null) {
       if (hConnections != null) {
         for (Connection conn : hConnections) {
           if (conn != null) {
@@ -92,7 +91,6 @@ public class MultiHConnection {
         hConnections = null;
       }
     }
-    }
     if (this.batchPool != null && !this.batchPool.isShutdown()) {
       this.batchPool.shutdown();
       try {

hbase-thrift/pom.xml

@@ -71,6 +71,15 @@
             </goals>
             <configuration>
               <skip>true</skip>
+             <properties>
+               <property>
+                 <name>listener</name>
+                 <value>org.apache.hadoop.hbase.ServerResourceCheckerJUnitListener</value>
+               </property>
+             </properties>
+             <systemPropertyVariables>
+               <test.build.webapps>target/test-classes/webapps</test.build.webapps>
+             </systemPropertyVariables>
             </configuration>
           </execution>
         </executions>

pom.xml

@@ -467,16 +467,6 @@
         <plugin>
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-release-plugin</artifactId>
-          <version>2.4.1</version>
-          <!--Making a release I've been using mvn 3.0 and specifying the apache-release
-              profile on the command line as follows:
-
-              $ ~/bin/mvn/bin/mvn  -Papache-release release:perform
-
-              I've also been kiling the release:prepare step mid-way to check the
-              release.properties it generates at the top-level.  Sometimes it refers
-              to HEAD rather than to the svn branch.
-           -->
           <configuration>
             <!--You need this profile. It'll sign your artifacts.
                 I'm not sure if this config. actually works though.
@@ -491,6 +481,7 @@
           </configuration>
         </plugin>
         <plugin>
+          <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-compiler-plugin</artifactId>
           <version>2.5.1</version>
           <configuration>
@@ -503,6 +494,7 @@
         </plugin>
         <!-- Test oriented plugins -->
         <plugin>
+          <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-surefire-plugin</artifactId>
           <version>${surefire.version}</version>
           <dependencies>
@@ -548,10 +540,12 @@
           </executions>
         </plugin>
         <plugin>
+          <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-surefire-report-plugin</artifactId>
           <version>${surefire.version}</version>
         </plugin>
         <plugin>
+          <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-clean-plugin</artifactId>
           <configuration>
             <filesets>
@@ -566,7 +560,8 @@
         <plugin>
           <groupId>org.codehaus.mojo</groupId>
           <artifactId>findbugs-maven-plugin</artifactId>
-          <version>${findbugs-maven-plugin.version}</version>
+          <version>3.0.0</version>
+          <!--NOTE: Findbugs 3.0.0 requires jdk7-->
           <configuration>
             <excludeFilterFile>${project.basedir}/../dev-support/findbugs-exclude.xml</excludeFilterFile>
             <findbugsXmlOutput>true</findbugsXmlOutput>
@@ -577,7 +572,7 @@
         <plugin>
           <groupId>org.codehaus.mojo</groupId>
           <artifactId>build-helper-maven-plugin</artifactId>
-          <version>1.5</version>
+          <version>1.9.1</version>
         </plugin>
         <plugin>
           <artifactId>maven-antrun-plugin</artifactId>
@@ -633,7 +628,7 @@
         <plugin>
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-eclipse-plugin</artifactId>
-          <version>2.8</version>
+          <version>2.9</version>
         </plugin>
         <!--This plugin's configuration is used to store Eclipse m2e settings only. It
           has no influence on the Maven build itself. m2e does not provide any safeguards against
@@ -650,7 +645,7 @@
           <!-- excludes are inherited -->
           <groupId>org.apache.rat</groupId>
           <artifactId>apache-rat-plugin</artifactId>
-          <version>0.8</version>
+          <version>0.11</version>
           <configuration>
             <excludes>
               <exclude>**/*.versionsBackup</exclude>
@@ -855,7 +850,6 @@
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-resources-plugin</artifactId>
-        <version>${maven.resources.plugin.version}</version>
         <!--$NO-MVN-MAN-VER$ -->
         <inherited>false</inherited>
         <executions>
@@ -903,7 +897,7 @@
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-site-plugin</artifactId>
-        <version>${maven.site.version}</version>
+        <version>3.4</version>
         <inherited>false</inherited>
         <dependencies>
           <dependency>
@@ -995,11 +989,8 @@
     <maven.assembly.version>2.4</maven.assembly.version>
     <maven.antrun.version>1.6</maven.antrun.version>
     <jamon.plugin.version>2.3.4</jamon.plugin.version>
-    <findbugs-maven-plugin.version>2.5.2</findbugs-maven-plugin.version>
     <findbugs-annotations>1.3.9-1</findbugs-annotations>
-    <maven.site.version>3.3</maven.site.version>
     <javadoc.version>2.9</javadoc.version>
-    <maven.resources.plugin.version>2.6</maven.resources.plugin.version>
     <!-- General Packaging -->
     <package.prefix>/usr</package.prefix>
     <package.conf.dir>/etc/hbase</package.conf.dir>