Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-3201 Add accounting of empty regioninfo_qualifier rows in meta to hbasefsck. 

git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1031801 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Michael Stack 2010-11-05 21:23:32 +00:00
parent 44eab92141
commit 70091702c5
3 changed files with 24 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
CHANGES.txt
View File

@ -1105,6 +1105,8 @@ Release 0.21.0 - Unreleased
HBASE-2819 hbck should have the ability to repair basic problems
HBASE-3200 Make is so can disable DEBUG logging on HConnectionImplemenation
without losing important messages
HBASE-3201 Add accounting of empty regioninfo_qualifier rows in meta to
hbasefsck.
NEW FEATURES
HBASE-1961 HBase EC2 scripts

1
src/main/java/org/apache/hadoop/hbase/catalog/MetaReader.java
View File

@ -506,6 +506,7 @@ public class MetaReader {
if (result != null && result.size() > 0) {
Pair<HRegionInfo, HServerInfo> pair =
metaRowToRegionPairWithInfo(result);
if (pair == null) continue;
if (pair.getSecond() == null || !pair.getSecond().equals(hsi)) {
continue;
}

27
src/main/java/org/apache/hadoop/hbase/client/HBaseFsck.java
View File

@ -46,6 +46,7 @@ import org.apache.hadoop.hbase.KeyValue;
import org.apache.hadoop.hbase.MasterNotRunningException;
import org.apache.hadoop.hbase.ZooKeeperConnectionException;
import org.apache.hadoop.hbase.client.MetaScanner.MetaScannerVisitor;
import org.apache.hadoop.hbase.client.Result;
import org.apache.hadoop.hbase.ipc.HRegionInterface;
import org.apache.hadoop.hbase.regionserver.wal.HLog;
import org.apache.hadoop.hbase.util.Bytes;
@ -76,6 +77,8 @@ public class HBaseFsck {
private boolean fix = false; // do we want to try fixing the errors?
private boolean rerun = false; // if we tried to fix something rerun hbck
private static boolean summary = false; // if we want to print less output
// Empty regioninfo qualifiers in .META.
private TreeSet<Result> emptyRegionInfoQualifiers = new TreeSet<Result>();
/**
* Constructor
@ -105,6 +108,8 @@ public class HBaseFsck {
// Make sure regionInfo is empty before starting
regionInfo.clear();
tablesInfo.clear();
emptyRegionInfoQualifiers.clear();
// get a list of all regions from the master. This involves
// scanning the META table
@ -166,6 +171,15 @@ public class HBaseFsck {
// Determine what's on HDFS
checkHdfs();
// Empty cells in .META.?
errors.print("Number of empty REGIONINFO_QUALIFIER rows in .META.: " +
emptyRegionInfoQualifiers.size());
if (details) {
for (Result r: emptyRegionInfoQualifiers) {
errors.print(" " + r);
}
}
// Check consistency
checkConsistency();
@ -626,14 +640,15 @@ public class HBaseFsck {
long ts = Collections.max(result.list(), comp).getTimestamp();
// record region details
byte[] value = result.getValue(HConstants.CATALOG_FAMILY,
HConstants.REGIONINFO_QUALIFIER);
HRegionInfo info = null;
byte [] value = result.getValue(HConstants.CATALOG_FAMILY,
HConstants.REGIONINFO_QUALIFIER);
if (value == null || value.length == 0) {
emptyRegionInfoQualifiers.add(result);
return true;
}
HRegionInfo info = Writables.getHRegionInfo(value);
HServerAddress server = null;
byte[] startCode = null;
if (value != null) {
info = Writables.getHRegionInfo(value);
}
// record assigned region server
value = result.getValue(HConstants.CATALOG_FAMILY,