Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-9103: Print lines that are longer than allowed in HadoopQA output. 

git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1509381 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
jyates 2013-08-01 18:43:42 +00:00
parent 9ab34a7dd7
commit 734e937179
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
dev-support/test-patch.sh
View File

@ -631,12 +631,15 @@ checkLineLengths () {
echo "" echo ""
#see http://en.wikipedia.org/wiki/Diff#Unified_format #see http://en.wikipedia.org/wiki/Diff#Unified_format
ll=`cat $PATCH_DIR/patch | grep "^+" | grep -v "^@@" | grep -v "^+++" | grep -v "import" | wc -L`
MAX_LINE_LENGTH_PATCH=`expr $MAX_LINE_LENGTH + 1` MAX_LINE_LENGTH_PATCH=`expr $MAX_LINE_LENGTH + 1`
lines=`cat $PATCH_DIR/patch | grep "^+" | grep -v "^@@" | grep -v "^+++" | grep -v "import" | awk -v len="$MAX_LINE_LENGTH_PATCH" 'length ($0) > len'
ll=`echo "$lines" | wc -l`
if [[ "$ll" -gt "$MAX_LINE_LENGTH_PATCH" ]]; then if [[ "$ll" -gt "$MAX_LINE_LENGTH_PATCH" ]]; then
JIRA_COMMENT="$JIRA_COMMENT JIRA_COMMENT="$JIRA_COMMENT
{color:red}-1 lineLengths{color}. The patch introduces lines longer than $MAX_LINE_LENGTH" {color:red}-1 lineLengths{color}. The patch introduces the following lines longer than $MAX_LINE_LENGTH:
$lines"
return 1 return 1
fi fi
JIRA_COMMENT="$JIRA_COMMENT JIRA_COMMENT="$JIRA_COMMENT