Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-13694 CallQueueSize is incorrectly decremented until the response is sent 

Signed-off-by: stack <stack@apache.org>
This commit is contained in:
Esteban Gutierrez 2015-05-15 00:57:15 -07:00 committed by stack
parent 5e7e626ef5
commit 74e5b26e57
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/CallRunner.java
View File

@ -45,6 +45,7 @@ public class CallRunner {
private Call call; private Call call;
private RpcServerInterface rpcServer; private RpcServerInterface rpcServer;
private MonitoredRPCHandler status; private MonitoredRPCHandler status;
private volatile boolean sucessful;
/** /**
* On construction, adds the size of this call to the running count of outstanding call sizes. * On construction, adds the size of this call to the running count of outstanding call sizes.
@ -116,6 +117,10 @@ public class CallRunner {
traceScope.close(); traceScope.close();
} }
RpcServer.CurCall.set(null); RpcServer.CurCall.set(null);
if (resultPair != null) {
this.rpcServer.addCallSize(call.getSize() * -1);
sucessful = true;
}
} }
// Set the response for undelayed calls and delayed calls with // Set the response for undelayed calls and delayed calls with
// undelayed responses. // undelayed responses.
@ -146,8 +151,9 @@ public class CallRunner {
RpcServer.LOG.warn(Thread.currentThread().getName() RpcServer.LOG.warn(Thread.currentThread().getName()
+ ": caught: " + StringUtils.stringifyException(e)); + ": caught: " + StringUtils.stringifyException(e));
} finally { } finally {
// regardless if successful or not we need to reset the callQueueSize if (!sucessful) {
this.rpcServer.addCallSize(call.getSize() * -1); this.rpcServer.addCallSize(call.getSize() * -1);
}
cleanup(); cleanup();
} }
} }