Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-25838 Use double instead of Double in StochasticLoadBalancer (#3221) 

Signed-off-by: Yulin Niu <niuyulin@apache.org>
This commit is contained in:
Duo Zhang 2021-05-04 09:04:47 +08:00 committed by GitHub
parent 6ad5b9e569
commit 762abe3bea
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
View File

@ -139,9 +139,9 @@ public class StochasticLoadBalancer extends BaseLoadBalancer {
private List<CostFunction> costFunctions; // FindBugs: Wants this protected; IS2_INCONSISTENT_SYNC private List<CostFunction> costFunctions; // FindBugs: Wants this protected; IS2_INCONSISTENT_SYNC
// to save and report costs to JMX // to save and report costs to JMX
private Double curOverallCost = 0d; private double curOverallCost = 0d;
private Double[] tempFunctionCosts; private double[] tempFunctionCosts;
private Double[] curFunctionCosts; private double[] curFunctionCosts;
// Keep locality based picker and cost function to alert them // Keep locality based picker and cost function to alert them
// when new services are offered // when new services are offered
@ -218,8 +218,8 @@ public class StochasticLoadBalancer extends BaseLoadBalancer {
addCostFunction(regionLoadFunctions[4]); addCostFunction(regionLoadFunctions[4]);
loadCustomCostFunctions(conf); loadCustomCostFunctions(conf);
curFunctionCosts= new Double[costFunctions.size()]; curFunctionCosts= new double[costFunctions.size()];
tempFunctionCosts= new Double[costFunctions.size()]; tempFunctionCosts= new double[costFunctions.size()];
isBalancerDecisionRecording = getConf() isBalancerDecisionRecording = getConf()
.getBoolean(BaseLoadBalancer.BALANCER_DECISION_BUFFER_ENABLED, .getBoolean(BaseLoadBalancer.BALANCER_DECISION_BUFFER_ENABLED,
@ -556,7 +556,7 @@ public class StochasticLoadBalancer extends BaseLoadBalancer {
/** /**
* update costs to JMX * update costs to JMX
*/ */
private void updateStochasticCosts(TableName tableName, Double overall, Double[] subCosts) { private void updateStochasticCosts(TableName tableName, double overall, double[] subCosts) {
if (tableName == null) { if (tableName == null) {
return; return;
} }
@ -572,7 +572,7 @@ public class StochasticLoadBalancer extends BaseLoadBalancer {
for (int i = 0; i < costFunctions.size(); i++) { for (int i = 0; i < costFunctions.size(); i++) {
CostFunction costFunction = costFunctions.get(i); CostFunction costFunction = costFunctions.get(i);
String costFunctionName = costFunction.getClass().getSimpleName(); String costFunctionName = costFunction.getClass().getSimpleName();
Double costPercent = (overall == 0) ? 0 : (subCosts[i] / overall); double costPercent = (overall == 0) ? 0 : (subCosts[i] / overall);
// TODO: cost function may need a specific description // TODO: cost function may need a specific description
balancer.updateStochasticCost(tableName.getNameAsString(), costFunctionName, balancer.updateStochasticCost(tableName.getNameAsString(), costFunctionName,
"The percent of " + costFunctionName, costPercent); "The percent of " + costFunctionName, costPercent);
@ -731,7 +731,7 @@ public class StochasticLoadBalancer extends BaseLoadBalancer {
} }
Float multiplier = c.getMultiplier(); Float multiplier = c.getMultiplier();
Double cost = c.cost(); double cost = c.cost();
this.tempFunctionCosts[i] = multiplier*cost; this.tempFunctionCosts[i] = multiplier*cost;
total += this.tempFunctionCosts[i]; total += this.tempFunctionCosts[i];