Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-15222 Addendum - Use less contended classes for metrics

This commit is contained in:
Elliott Clark 2016-02-25 09:08:11 -08:00
parent 43f99def67
commit 77133fd225
3 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
hbase-common/src/main/java/org/apache/hadoop/hbase/util/FastLongHistogram.java
View File

@ -310,12 +310,8 @@ public class FastLongHistogram {
* Resets the histogram for new counting. * Resets the histogram for new counting.
*/ */
public FastLongHistogram reset() { public FastLongHistogram reset() {
if (this.bins.hasData.get()) { Bins oldBins = this.bins;
Bins oldBins = this.bins; this.bins = new Bins(this.bins, this.bins.counts.length - 3, 0.01, 0.99);
this.bins = new Bins(this.bins, this.bins.counts.length - 3, 0.01, 0.99); return new FastLongHistogram(oldBins);
return new FastLongHistogram(oldBins);
}
return null;
} }
} }

4
hbase-hadoop2-compat/src/main/java/org/apache/hadoop/metrics2/lib/MutableHistogram.java
View File

@ -63,7 +63,9 @@ public class MutableHistogram extends MutableMetric implements MetricHistogram {
public synchronized void snapshot(MetricsRecordBuilder metricsRecordBuilder, boolean all) { public synchronized void snapshot(MetricsRecordBuilder metricsRecordBuilder, boolean all) {
// Get a reference to the old histogram. // Get a reference to the old histogram.
FastLongHistogram histo = histogram.reset(); FastLongHistogram histo = histogram.reset();
updateSnapshotMetrics(metricsRecordBuilder, histo); if (histo != null) {
updateSnapshotMetrics(metricsRecordBuilder, histo);
}
} }
protected void updateSnapshotMetrics(MetricsRecordBuilder metricsRecordBuilder, protected void updateSnapshotMetrics(MetricsRecordBuilder metricsRecordBuilder,

6
hbase-hadoop2-compat/src/main/java/org/apache/hadoop/metrics2/lib/MutableRangeHistogram.java
View File

@ -56,8 +56,10 @@ public abstract class MutableRangeHistogram extends MutableHistogram implements
public synchronized void snapshot(MetricsRecordBuilder metricsRecordBuilder, boolean all) { public synchronized void snapshot(MetricsRecordBuilder metricsRecordBuilder, boolean all) {
// Get a reference to the old histogram. // Get a reference to the old histogram.
FastLongHistogram histo = histogram.reset(); FastLongHistogram histo = histogram.reset();
updateSnapshotMetrics(metricsRecordBuilder, histo); if (histo != null) {
updateSnapshotRangeMetrics(metricsRecordBuilder, histo); updateSnapshotMetrics(metricsRecordBuilder, histo);
updateSnapshotRangeMetrics(metricsRecordBuilder, histo);
}
} }
public void updateSnapshotRangeMetrics(MetricsRecordBuilder metricsRecordBuilder, public void updateSnapshotRangeMetrics(MetricsRecordBuilder metricsRecordBuilder,