Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-2892 Replication metrics aren't updated 

git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@980993 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Jean-Daniel Cryans 2010-07-30 23:37:19 +00:00
parent b3db1e976e
commit 77aef8f799
3 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGES.txt
View File

@ -463,6 +463,7 @@ Release 0.21.0 - Unreleased
HBASE-2890 Initialize RPC JMX metrics on startup (Gary Helmling via Stack) HBASE-2890 Initialize RPC JMX metrics on startup (Gary Helmling via Stack)
HBASE-2755 Duplicate assignment of a region after region server recovery HBASE-2755 Duplicate assignment of a region after region server recovery
(Kannan Muthukkaruppan via Stack) (Kannan Muthukkaruppan via Stack)
HBASE-2892 Replication metrics aren't updated
IMPROVEMENTS IMPROVEMENTS
HBASE-1760 Cleanup TODOs in HTable HBASE-1760 Cleanup TODOs in HTable

3
src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSinkMetrics.java
View File

@ -58,8 +58,6 @@ public class ReplicationSinkMetrics implements Updater {
metricsRecord = MetricsUtil.createRecord(context, "replication"); metricsRecord = MetricsUtil.createRecord(context, "replication");
metricsRecord.setTag("RegionServer", name); metricsRecord.setTag("RegionServer", name);
context.registerUpdater(this); context.registerUpdater(this);
// Add jvmmetrics.
JvmMetrics.init("RegionServer", name);
// export for JMX // export for JMX
new ReplicationStatistics(this.registry, "ReplicationSink"); new ReplicationStatistics(this.registry, "ReplicationSink");
} }
@ -78,5 +76,6 @@ public class ReplicationSinkMetrics implements Updater {
this.appliedBatchesRate.pushMetric(this.metricsRecord); this.appliedBatchesRate.pushMetric(this.metricsRecord);
this.ageOfLastAppliedOp.pushMetric(this.metricsRecord); this.ageOfLastAppliedOp.pushMetric(this.metricsRecord);
} }
this.metricsRecord.update();
} }
} }

3
src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceMetrics.java
View File

@ -73,8 +73,6 @@ public class ReplicationSourceMetrics implements Updater {
metricsRecord = MetricsUtil.createRecord(context, "replication"); metricsRecord = MetricsUtil.createRecord(context, "replication");
metricsRecord.setTag("RegionServer", name); metricsRecord.setTag("RegionServer", name);
context.registerUpdater(this); context.registerUpdater(this);
// Add jvmmetrics.
JvmMetrics.init("RegionServer", name);
// export for JMX // export for JMX
new ReplicationStatistics(this.registry, "ReplicationSource for " + id); new ReplicationStatistics(this.registry, "ReplicationSource for " + id);
} }
@ -97,5 +95,6 @@ public class ReplicationSourceMetrics implements Updater {
this.ageOfLastShippedOp.pushMetric(this.metricsRecord); this.ageOfLastShippedOp.pushMetric(this.metricsRecord);
this.sizeOfLogQueue.pushMetric(this.metricsRecord); this.sizeOfLogQueue.pushMetric(this.metricsRecord);
} }
this.metricsRecord.update();
} }
} }