diff --git a/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/BlockCacheTmpl.jamon b/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/BlockCacheTmpl.jamon index 68063219d08..f7abdc80dd3 100644 --- a/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/BlockCacheTmpl.jamon +++ b/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/BlockCacheTmpl.jamon @@ -30,6 +30,7 @@ BlockCache bc; %java> <%import> java.util.Map; +org.apache.hadoop.hbase.io.hfile.BlockCacheUtil; org.apache.hadoop.hbase.io.hfile.BlockCacheUtil.CachedBlocksByFile; org.apache.hadoop.hbase.io.hfile.AgeSnapshot; org.apache.hadoop.hbase.io.hfile.CachedBlock; @@ -281,9 +282,7 @@ are combined counts. Request count is sum of hits and misses.
<%java> String bcUrl = "http://hbase.apache.org/devapidocs/" + bc.getClass().getName().replaceAll("\\.", "/") + ".html"; String bcName = bc.getClass().getSimpleName(); - org.apache.hadoop.hbase.io.hfile.BlockCacheUtil.CachedBlocksByFile cbsbf = - org.apache.hadoop.hbase.io.hfile.BlockCacheUtil.getLoadedCachedBlocksByFile(config, bc); - AgeSnapshot cbsbfSnapshot = cbsbf.getAgeInCacheSnapshot(); + int maxCachedBlocksByFile = BlockCacheUtil.getMaxCachedBlocksByFile(config); boolean bucketCache = bc.getClass().getSimpleName().equals("BucketCache"); BucketCacheStats bucketCacheStats = null; @@ -294,13 +293,6 @@ are combined counts. Request count is sum of hits and misses. bucketAllocator = ((BucketCache)bc).getAllocator(); } %java> -<%if cbsbf.isFull() %> --
Attribute | @@ -365,9 +357,13 @@ are combined counts. Request count is sum of hits and misses. %if>
---|
View block cache as JSON | Block cache as JSON by file
-<%java> -cbsbf = null; -%java> +
+View block cache as JSON | Block cache as JSON by file
+<%if bc.getBlockCount() > maxCachedBlocksByFile %>
+
+Note: JSON view of block cache will be incomplete, because block count <% bc.getBlockCount() %> is greater than hbase.ui.blockcache.by.file.max value of <% maxCachedBlocksByFile %>.
+Increase that value to get a complete picture.
+%if>
+