Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-27017: MOB snapshot is broken when FileBased SFT is used (#4466) 

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
This commit is contained in:
BukrosSzabolcs 2022-06-05 20:51:28 +02:00 committed by Wellington Chevreuil
parent 5a13ad8137
commit 8139cf6477
1 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotManifest.java
View File

@ -36,6 +36,7 @@ import org.apache.hadoop.fs.FileStatus;
import org.apache.hadoop.fs.FileSystem; import org.apache.hadoop.fs.FileSystem;
import org.apache.hadoop.fs.Path; import org.apache.hadoop.fs.Path;
import org.apache.hadoop.hbase.client.ColumnFamilyDescriptor; import org.apache.hadoop.hbase.client.ColumnFamilyDescriptor;
import org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder;
import org.apache.hadoop.hbase.client.RegionInfo; import org.apache.hadoop.hbase.client.RegionInfo;
import org.apache.hadoop.hbase.client.TableDescriptor; import org.apache.hadoop.hbase.client.TableDescriptor;
import org.apache.hadoop.hbase.errorhandling.ForeignExceptionSnare; import org.apache.hadoop.hbase.errorhandling.ForeignExceptionSnare;
@ -310,7 +311,17 @@ public final class SnapshotManifest {
for (ColumnFamilyDescriptor cfd : htd.getColumnFamilies()) { for (ColumnFamilyDescriptor cfd : htd.getColumnFamilies()) {
Object familyData = visitor.familyOpen(regionData, cfd.getName()); Object familyData = visitor.familyOpen(regionData, cfd.getName());
monitor.rethrowException(); monitor.rethrowException();
StoreFileTracker tracker = StoreFileTrackerFactory.create(conf, htd, cfd, regionFs); StoreFileTracker tracker = null;
if (isMobRegion) {
// MOB regions are always using the default SFT implementation
ColumnFamilyDescriptor defaultSFTCfd = ColumnFamilyDescriptorBuilder.newBuilder(cfd)
.setValue(StoreFileTrackerFactory.TRACKER_IMPL,
StoreFileTrackerFactory.Trackers.DEFAULT.name())
.build();
tracker = StoreFileTrackerFactory.create(conf, htd, defaultSFTCfd, regionFs);
} else {
tracker = StoreFileTrackerFactory.create(conf, htd, cfd, regionFs);
}
List<StoreFileInfo> storeFiles = tracker.load(); List<StoreFileInfo> storeFiles = tracker.load();
if (storeFiles.isEmpty()) { if (storeFiles.isEmpty()) {
LOG.debug("No files under family: {}", cfd.getNameAsString()); LOG.debug("No files under family: {}", cfd.getNameAsString());