Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-19110 Add default for Server#isStopping & #getFileSystem

This commit is contained in:
Michael Stack 2017-10-27 09:39:06 -07:00
parent 52e3664680
commit 817dc5644c
No known key found for this signature in database
GPG Key ID: 9816C7FC8ACC93D2
1 changed files with 19 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
hbase-server/src/main/java/org/apache/hadoop/hbase/Server.java
View File

@ -26,6 +26,8 @@ import org.apache.hadoop.hbase.zookeeper.MetaTableLocator;
import org.apache.hadoop.hbase.zookeeper.ZooKeeperWatcher; import org.apache.hadoop.hbase.zookeeper.ZooKeeperWatcher;
import org.apache.yetus.audience.InterfaceAudience; import org.apache.yetus.audience.InterfaceAudience;
import java.io.IOException;
/** /**
* Defines a curated set of shared functions implemented by HBase servers (Masters * Defines a curated set of shared functions implemented by HBase servers (Masters
* and RegionServers). For use internally only. Be judicious adding API. Changes cause ripples * and RegionServers). For use internally only. Be judicious adding API. Changes cause ripples
@ -83,15 +85,29 @@ public interface Server extends Abortable, Stoppable {
ChoreService getChoreService(); ChoreService getChoreService();
/** /**
* @return Return the FileSystem object used. * @return Return the FileSystem object used (can return null!).
*/ */
// TODO: On Master, return Master's. On RegionServer, return RegionServers. The FileSystems // TODO: On Master, return Master's. On RegionServer, return RegionServers. The FileSystems
// may differ. TODO. // may differ. TODO.
FileSystem getFileSystem(); default FileSystem getFileSystem() {
// This default is pretty dodgy!
Configuration c = getConfiguration();
FileSystem fs = null;
try {
if (c != null) {
fs = FileSystem.get(c);
}
} catch (IOException e) {
// If an exception, just return null
}
return fs;
};
/** /**
* @return True is the server is Stopping * @return True is the server is Stopping
*/ */
// Note: This method is not part of the Stoppable Interface. // Note: This method is not part of the Stoppable Interface.
boolean isStopping(); default boolean isStopping() {
return false;
}
} }