From 8219ec749331eb163060f5ffbeedd8ae826ebfe1 Mon Sep 17 00:00:00 2001
From: Nihal Jain <nihaljain.cs@gmail.com>
Date: Wed, 18 Apr 2018 23:03:07 +0530
Subject: [PATCH] HBASE-20438 Add an HBase antipattern check for reintroducing
 commons-logging

Signed-off-by: Sean Busbey <busbey@apache.org>
---
 dev-support/hbase-personality.sh | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/dev-support/hbase-personality.sh b/dev-support/hbase-personality.sh
index 219891387f7..b0105035531 100755
--- a/dev-support/hbase-personality.sh
+++ b/dev-support/hbase-personality.sh
@@ -642,6 +642,12 @@ function hbaseanti_patchfile
     ((result=result+1))
   fi
 
+  warnings=$(${GREP} -cE 'org.apache.commons.logging.Log(Factory|;)' "${patchfile}")
+  if [[ ${warnings} -gt 0 ]]; then
+    add_vote_table -1 hbaseanti "" "The patch appears to use commons-logging instead of slf4j."
+    ((result=result+1))
+  fi
+
   if [[ ${result} -gt 0 ]]; then
     return 1
   fi