Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-14519 Purge TestFavoredNodeAssignmentHelper, a test for an abandoned feature that can hang

This commit is contained in:
stack 2015-10-02 13:29:39 -07:00
parent 26dec4c60d
commit 83f5663a22
1 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestFavoredNodeAssignmentHelper.java
View File

@ -39,6 +39,7 @@ import org.apache.hadoop.hbase.util.Bytes;
import org.apache.hadoop.hbase.util.Triple; import org.apache.hadoop.hbase.util.Triple;
import org.junit.BeforeClass; import org.junit.BeforeClass;
import org.junit.Test; import org.junit.Test;
import org.junit.Ignore;
import org.junit.experimental.categories.Category; import org.junit.experimental.categories.Category;
import org.mockito.Mockito; import org.mockito.Mockito;
@ -98,7 +99,7 @@ public class TestFavoredNodeAssignmentHelper {
return chosenServers; return chosenServers;
} }
@Test @Ignore("Disabled for now until FavoredNodes gets finished as a feature") @Test
public void testSmallCluster() { public void testSmallCluster() {
// Test the case where we cannot assign favored nodes (because the number // Test the case where we cannot assign favored nodes (because the number
// of nodes in the cluster is too less) // of nodes in the cluster is too less)
@ -110,7 +111,7 @@ public class TestFavoredNodeAssignmentHelper {
assertFalse(helper.canPlaceFavoredNodes()); assertFalse(helper.canPlaceFavoredNodes());
} }
@Test @Ignore("Disabled for now until FavoredNodes gets finished as a feature") @Test
public void testPlacePrimaryRSAsRoundRobin() { public void testPlacePrimaryRSAsRoundRobin() {
// Test the regular case where there are many servers in different racks // Test the regular case where there are many servers in different racks
// Test once for few regions and once for many regions // Test once for few regions and once for many regions
@ -119,7 +120,7 @@ public class TestFavoredNodeAssignmentHelper {
primaryRSPlacement(600, null, 10, 10, 10); primaryRSPlacement(600, null, 10, 10, 10);
} }
@Test @Ignore("Disabled for now until FavoredNodes gets finished as a feature") @Test
public void testRoundRobinAssignmentsWithUnevenSizedRacks() { public void testRoundRobinAssignmentsWithUnevenSizedRacks() {
//In the case of uneven racks, the regions should be distributed //In the case of uneven racks, the regions should be distributed
//proportionately to the rack sizes //proportionately to the rack sizes
@ -136,7 +137,7 @@ public class TestFavoredNodeAssignmentHelper {
primaryRSPlacement(459, null, 7, 9, 8); primaryRSPlacement(459, null, 7, 9, 8);
} }
@Test @Ignore("Disabled for now until FavoredNodes gets finished as a feature") @Test
public void testSecondaryAndTertiaryPlacementWithSingleRack() { public void testSecondaryAndTertiaryPlacementWithSingleRack() {
// Test the case where there is a single rack and we need to choose // Test the case where there is a single rack and we need to choose
// Primary/Secondary/Tertiary from a single rack. // Primary/Secondary/Tertiary from a single rack.
@ -160,7 +161,7 @@ public class TestFavoredNodeAssignmentHelper {
} }
} }
@Test @Ignore("Disabled for now until FavoredNodes gets finished as a feature") @Test
public void testSecondaryAndTertiaryPlacementWithSingleServer() { public void testSecondaryAndTertiaryPlacementWithSingleServer() {
// Test the case where we have a single node in the cluster. In this case // Test the case where we have a single node in the cluster. In this case
// the primary can be assigned but the secondary/tertiary would be null // the primary can be assigned but the secondary/tertiary would be null
@ -178,7 +179,7 @@ public class TestFavoredNodeAssignmentHelper {
assertTrue(secondaryAndTertiaryMap.get(regions.get(0)) == null); assertTrue(secondaryAndTertiaryMap.get(regions.get(0)) == null);
} }
@Test @Ignore("Disabled for now until FavoredNodes gets finished as a feature") @Test
public void testSecondaryAndTertiaryPlacementWithMultipleRacks() { public void testSecondaryAndTertiaryPlacementWithMultipleRacks() {
// Test the case where we have multiple racks and the region servers // Test the case where we have multiple racks and the region servers
// belong to multiple racks // belong to multiple racks
@ -207,7 +208,7 @@ public class TestFavoredNodeAssignmentHelper {
} }
} }
@Test @Ignore("Disabled for now until FavoredNodes gets finished as a feature") @Test
public void testSecondaryAndTertiaryPlacementWithLessThanTwoServersInRacks() { public void testSecondaryAndTertiaryPlacementWithLessThanTwoServersInRacks() {
// Test the case where we have two racks but with less than two servers in each // Test the case where we have two racks but with less than two servers in each
// We will not have enough machines to select secondary/tertiary // We will not have enough machines to select secondary/tertiary
@ -228,7 +229,7 @@ public class TestFavoredNodeAssignmentHelper {
} }
} }
@Test @Ignore("Disabled for now until FavoredNodes gets finished as a feature") @Test
public void testSecondaryAndTertiaryPlacementWithMoreThanOneServerInPrimaryRack() { public void testSecondaryAndTertiaryPlacementWithMoreThanOneServerInPrimaryRack() {
// Test the case where there is only one server in one rack and another rack // Test the case where there is only one server in one rack and another rack
// has more servers. We try to choose secondary/tertiary on different // has more servers. We try to choose secondary/tertiary on different