Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-26190 High rate logging of BucketAllocatorException: Allocation too big - Addendum (#3792)

This commit is contained in:
Anoop Sam John 2021-10-24 09:19:10 +05:30 committed by GitHub
parent 9e47358ecb
commit 84a527bdcc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java
View File

@ -1011,16 +1011,17 @@ public class BucketCache implements BlockCache, HeapSize {
*/ */
private String getAllocationFailWarningMessage(RAMQueueEntry re) { private String getAllocationFailWarningMessage(RAMQueueEntry re) {
if (re != null && re.getData() instanceof HFileBlock) { if (re != null && re.getData() instanceof HFileBlock) {
HFileBlock block = (HFileBlock) re.getData(); HFileContext fileContext = ((HFileBlock) re.getData()).getHFileContext();
HFileContext fileContext = block.getHFileContext();
String hFileName = fileContext.getHFileName();
String columnFamily = Bytes.toString(fileContext.getColumnFamily()); String columnFamily = Bytes.toString(fileContext.getColumnFamily());
String tableName = Bytes.toString(fileContext.getTableName()); String tableName = Bytes.toString(fileContext.getTableName());
return ("Most recent failed allocation in " + ALLOCATION_FAIL_LOG_TIME_PERIOD if (tableName != null && columnFamily != null) {
+ " milliseconds; Table Name = " + tableName + ", Column Family = " return ("Most recent failed allocation in " + ALLOCATION_FAIL_LOG_TIME_PERIOD
+ columnFamily + ", HFile Name : " + hFileName); + " milliseconds; Table Name = " + tableName + ", Column Family = " + columnFamily
+ ", HFile Name : " + fileContext.getHFileName());
}
} }
return ("Failed allocation for " + (re == null ? "" : re.getKey()) + "; "); return ("Most recent failed allocation in " + ALLOCATION_FAIL_LOG_TIME_PERIOD
+ " milliseconds; HFile Name : " + (re == null ? "" : re.getKey()));
} }
/** /**
@ -1068,7 +1069,7 @@ public class BucketCache implements BlockCache, HeapSize {
} }
index++; index++;
} catch (BucketAllocatorException fle) { } catch (BucketAllocatorException fle) {
long currTs = System.currentTimeMillis(); // Current time since Epoch in milliseconds. long currTs = EnvironmentEdgeManager.currentTime();
cacheStats.allocationFailed(); // Record the warning. cacheStats.allocationFailed(); // Record the warning.
if (allocFailLogPrevTs == 0 || (currTs - allocFailLogPrevTs) > ALLOCATION_FAIL_LOG_TIME_PERIOD) { if (allocFailLogPrevTs == 0 || (currTs - allocFailLogPrevTs) > ALLOCATION_FAIL_LOG_TIME_PERIOD) {
LOG.warn (getAllocationFailWarningMessage(re), fle); LOG.warn (getAllocationFailWarningMessage(re), fle);