Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-967 [Optimization] Cache cell maximum length (HCD.getMaxValueLength); its used checking batch size 

git-svn-id: https://svn.apache.org/repos/asf/hadoop/hbase/trunk@708376 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Michael Stack 2008-10-27 23:22:29 +00:00
parent 4c550fb6b9
commit 85fcfc11ca
2 changed files with 20 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
src/java/org/apache/hadoop/hbase/HColumnDescriptor.java
View File

@ -86,6 +86,14 @@ public class HColumnDescriptor implements WritableComparable {
* Default maximum cell length.
*/
public static final int DEFAULT_LENGTH = Integer.MAX_VALUE;
public static final Integer DEFAULT_LENGTH_INTEGER =
Integer.valueOf(DEFAULT_LENGTH);
/*
* Cache here the HCD value.
* Question: its OK to cache since when we're reenable, we create a new HCD?
*/
private volatile Integer maxValueLength = null;
/**
* Default setting for whether to serve from memory or not.
@ -322,7 +330,7 @@ public class HColumnDescriptor implements WritableComparable {
public int getMaxVersions() {
String value = getValue(HConstants.VERSIONS);
if (value != null)
return Integer.valueOf(value);
return Integer.valueOf(value).intValue();
return DEFAULT_VERSIONS;
}
@ -359,7 +367,7 @@ public class HColumnDescriptor implements WritableComparable {
public boolean isInMemory() {
String value = getValue(HConstants.IN_MEMORY);
if (value != null)
return Boolean.valueOf(value);
return Boolean.valueOf(value).booleanValue();
return DEFAULT_IN_MEMORY;
}
@ -374,11 +382,13 @@ public class HColumnDescriptor implements WritableComparable {
/**
* @return Maximum value length.
*/
public int getMaxValueLength() {
String value = getValue(LENGTH);
if (value != null)
return Integer.valueOf(value);
return DEFAULT_LENGTH;
public synchronized int getMaxValueLength() {
if (this.maxValueLength == null) {
String value = getValue(LENGTH);
this.maxValueLength = (value != null)?
Integer.decode(value): DEFAULT_LENGTH_INTEGER;
}
return this.maxValueLength.intValue();
}
/**
@ -386,6 +396,7 @@ public class HColumnDescriptor implements WritableComparable {
*/
public void setMaxValueLength(int maxLength) {
setValue(LENGTH, Integer.toString(maxLength));
this.maxValueLength = null;
}
/**
@ -426,7 +437,7 @@ public class HColumnDescriptor implements WritableComparable {
public boolean isBloomfilter() {
String value = getValue(BLOOMFILTER);
if (value != null)
return Boolean.valueOf(value);
return Boolean.valueOf(value).booleanValue();
return DEFAULT_BLOOMFILTER;
}
@ -444,7 +455,7 @@ public class HColumnDescriptor implements WritableComparable {
public int getMapFileIndexInterval() {
String value = getValue(MAPFILE_INDEX_INTERVAL);
if (value != null)
return Integer.valueOf(value);
return Integer.valueOf(value).intValue();
return DEFAULT_MAPFILE_INDEX_INTERVAL;
}

1
src/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
View File

@ -1208,7 +1208,6 @@ public class HRegionServer implements HConstants, HRegionInterface, Runnable {
HTableDescriptor desc = region.getTableDesc();
for (Iterator<BatchOperation> iter =
batchUpdate.iterator(); iter.hasNext();) {
BatchOperation operation = iter.next();
if (operation.getValue() != null) {
HColumnDescriptor fam =