Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-19726 Failed to start HMaster due to infinite retrying on meta assign

This commit is contained in:
Michael Stack 2018-02-02 18:29:33 -08:00
parent fdbc843516
commit 897afb7d18
No known key found for this signature in database
GPG Key ID: 9816C7FC8ACC93D2
1 changed files with 13 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
hbase-server/src/main/java/org/apache/hadoop/hbase/master/TableStateManager.java
View File

@ -25,6 +25,7 @@ import java.util.concurrent.locks.ReadWriteLock;
import java.util.concurrent.locks.ReentrantReadWriteLock; import java.util.concurrent.locks.ReentrantReadWriteLock;
import org.apache.hadoop.hbase.client.TableDescriptor; import org.apache.hadoop.hbase.client.TableDescriptor;
import org.apache.hadoop.hbase.exceptions.IllegalArgumentIOException;
import org.apache.hbase.thirdparty.com.google.common.collect.Sets; import org.apache.hbase.thirdparty.com.google.common.collect.Sets;
import edu.umd.cs.findbugs.annotations.NonNull; import edu.umd.cs.findbugs.annotations.NonNull;
import edu.umd.cs.findbugs.annotations.Nullable; import edu.umd.cs.findbugs.annotations.Nullable;
@ -66,7 +67,7 @@ public class TableStateManager {
public void setTableState(TableName tableName, TableState.State newState) throws IOException { public void setTableState(TableName tableName, TableState.State newState) throws IOException {
lock.writeLock().lock(); lock.writeLock().lock();
try { try {
udpateMetaState(tableName, newState); updateMetaState(tableName, newState);
} finally { } finally {
lock.writeLock().unlock(); lock.writeLock().unlock();
} }
@ -93,7 +94,7 @@ public class TableStateManager {
throw new TableNotFoundException(tableName); throw new TableNotFoundException(tableName);
} }
if (currentState.inStates(states)) { if (currentState.inStates(states)) {
udpateMetaState(tableName, newState); updateMetaState(tableName, newState);
return null; return null;
} else { } else {
return currentState.getState(); return currentState.getState();
@ -121,7 +122,7 @@ public class TableStateManager {
throw new TableNotFoundException(tableName); throw new TableNotFoundException(tableName);
} }
if (!currentState.inStates(states)) { if (!currentState.inStates(states)) {
udpateMetaState(tableName, newState); updateMetaState(tableName, newState);
return true; return true;
} else { } else {
return false; return false;
@ -178,8 +179,16 @@ public class TableStateManager {
return currentState.getState(); return currentState.getState();
} }
protected void udpateMetaState(TableName tableName, TableState.State newState) protected void updateMetaState(TableName tableName, TableState.State newState)
throws IOException { throws IOException {
if (tableName.equals(TableName.META_TABLE_NAME)) {
if (TableState.State.DISABLING.equals(newState) ||
TableState.State.DISABLED.equals(newState)) {
throw new IllegalArgumentIOException("Cannot disable the meta table; " + newState);
}
// Otherwise, just return; no need to set ENABLED on meta -- it is always ENABLED.
return;
}
MetaTableAccessor.updateTableState(master.getConnection(), tableName, newState); MetaTableAccessor.updateTableState(master.getConnection(), tableName, newState);
} }