Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-2140 findbugs issues - 2 performance warnings as suggested by findbugs 

git-svn-id: https://svn.apache.org/repos/asf/hadoop/hbase/trunk@900208 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Michael Stack 2010-01-17 20:08:59 +00:00
parent b2da74b0ac
commit 8bc2888278
3 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
CHANGES.txt
View File

@ -175,6 +175,8 @@ Release 0.21.0 - Unreleased
HBASE-2135 ant javadoc complains about missing classe (Kay Kay via Stack) HBASE-2135 ant javadoc complains about missing classe (Kay Kay via Stack)
HBASE-2130 bin/* scripts - not to include lib/test/**/*.jar HBASE-2130 bin/* scripts - not to include lib/test/**/*.jar
(Kay Kay via Stack) (Kay Kay via Stack)
HBASE-2140 findbugs issues - 2 performance warnings as suggested by findbugs
(Kay Kay via Stack)
IMPROVEMENTS IMPROVEMENTS
HBASE-1760 Cleanup TODOs in HTable HBASE-1760 Cleanup TODOs in HTable

5
src/java/org/apache/hadoop/hbase/client/Scan.java
View File

@ -136,8 +136,9 @@ public class Scan implements Writable {
TimeRange ctr = scan.getTimeRange(); TimeRange ctr = scan.getTimeRange();
tr = new TimeRange(ctr.getMin(), ctr.getMax()); tr = new TimeRange(ctr.getMin(), ctr.getMax());
Map<byte[], NavigableSet<byte[]>> fams = scan.getFamilyMap(); Map<byte[], NavigableSet<byte[]>> fams = scan.getFamilyMap();
for (byte[] fam : fams.keySet()) { for (Map.Entry<byte[],NavigableSet<byte[]>> entry : fams.entrySet()) {
NavigableSet<byte[]> cols = fams.get(fam); byte [] fam = entry.getKey();
NavigableSet<byte[]> cols = entry.getValue();
if (cols != null && cols.size() > 0) { if (cols != null && cols.size() > 0) {
for (byte[] col : cols) { for (byte[] col : cols) {
addColumn(fam, col); addColumn(fam, col);

4
src/java/org/apache/hadoop/hbase/util/FSUtils.java
View File

@ -446,11 +446,11 @@ public class FSUtils {
} }
} }
// compute percentage per table and store in result list // compute percentage per table and store in result list
frags.put(d.getName(), new Integer( frags.put(d.getName(), Integer.valueOf(
Math.round((float) cfFrag / cfCount * 100))); Math.round((float) cfFrag / cfCount * 100)));
} }
// set overall percentage for all tables // set overall percentage for all tables
frags.put("-TOTAL-", new Integer( frags.put("-TOTAL-", Integer.valueOf(
Math.round((float) cfFragTotal / cfCountTotal * 100))); Math.round((float) cfFragTotal / cfCountTotal * 100)));
return frags; return frags;
} }