Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-20438 Add an HBase antipattern check for reintroducing commons-logging 

Signed-off-by: Sean Busbey <busbey@apache.org>
This commit is contained in:
Nihal Jain 2018-04-18 23:03:07 +05:30 committed by Sean Busbey
parent 22e7ae0311
commit 8c7293c514
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
dev-support/hbase-personality.sh
View File

@ -642,6 +642,12 @@ function hbaseanti_patchfile
((result=result+1)) ((result=result+1))
fi fi
warnings=$(${GREP} -cE 'org.apache.commons.logging.Log(Factory|;)' "${patchfile}")
if [[ ${warnings} -gt 0 ]]; then
add_vote_table -1 hbaseanti "" "The patch appears to use commons-logging instead of slf4j."
((result=result+1))
fi
if [[ ${result} -gt 0 ]]; then if [[ ${result} -gt 0 ]]; then
return 1 return 1
fi fi