Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-20410 update protoc to 3.5.1-1 for rhel6

This commit is contained in:
Mike Drob 2018-04-13 09:44:59 -05:00
parent bd2dddae60
commit 8cd1201afe
2 changed files with 3 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
hbase-protocol-shaded/pom.xml
View File

@ -33,8 +33,10 @@
<maven.javadoc.skip>true</maven.javadoc.skip> <maven.javadoc.skip>true</maven.javadoc.skip>
<!--Version of protobuf that hbase uses internally (we shade our pb) <!--Version of protobuf that hbase uses internally (we shade our pb)
Must match what is out in hbase-thirdparty include. Must match what is out in hbase-thirdparty include.
3.5.1-1 is the same as 3.5.1 except includes corrected binaries for el6
to work around https://github.com/google/protobuf/issues/4109
--> -->
<internal.protobuf.version>3.5.1</internal.protobuf.version> <internal.protobuf.version>3.5.1-1</internal.protobuf.version>
</properties> </properties>
<build> <build>
<resources> <resources>

12
src/main/asciidoc/_chapters/developer.adoc
View File

@ -433,18 +433,6 @@ convenience; however, the plugin may not be able to retrieve appropriate binarie
on a platform where protoc fails, you will have to compile protoc from source, and run it independent of our maven build. on a platform where protoc fails, you will have to compile protoc from source, and run it independent of our maven build.
You can disable the inline code generation by specifying `-Dprotoc.skip` in your maven arguments, allowing your build to proceed further. You can disable the inline code generation by specifying `-Dprotoc.skip` in your maven arguments, allowing your build to proceed further.
A similar failure relates to the stock CentOS 6 docker image providing a too old version of glibc for the version of protoc that we use.
In this case, you would have to install glibc 2.14 and protoc 3.5.1 manually, then execute something like:
[source,bourne]
----
cd hbase-protocol-shaded
LD_LIBRARY_PATH=/opt/glibc-2.14/lib protoc \
--proto_path=src/main/protobuf \
--java_out=target/generated-sources/protobuf/java \
src/main/protobuf/*.proto
----
[NOTE] [NOTE]
If you need to manually generate your protobuf files, you should not use `clean` in subsequent maven calls, as that will delete the newly generated files. If you need to manually generate your protobuf files, you should not use `clean` in subsequent maven calls, as that will delete the newly generated files.