Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-4861 Fix some misspells and extraneous characters in logs; set some to TRACE 

git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1205732 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Michael Stack 2011-11-24 06:13:10 +00:00
parent fc20e56a0f
commit 8d056194e1
9 changed files with 19 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/main/java/org/apache/hadoop/hbase/HRegionInfo.java
View File

@ -655,9 +655,8 @@ implements WritableComparable<HRegionInfo> {
*/
@Override
public String toString() {
return "REGION => {" + HConstants.NAME + " => '" +
return "{" + HConstants.NAME + " => '" +
this.regionNameStr
+ "', TableName => '" + Bytes.toStringBinary(this.tableName)
+ "', STARTKEY => '" +
Bytes.toStringBinary(this.startKey) + "', ENDKEY => '" +
Bytes.toStringBinary(this.endKey) +

7
src/main/java/org/apache/hadoop/hbase/catalog/MetaEditor.java
View File

@ -289,8 +289,9 @@ public class MetaEditor {
delete.deleteColumns(HConstants.CATALOG_FAMILY, HConstants.SPLITA_QUALIFIER);
delete.deleteColumns(HConstants.CATALOG_FAMILY, HConstants.SPLITB_QUALIFIER);
deleteMetaTable(catalogTracker, delete);
LOG.info("Deleted daughters references, qualifier=" + Bytes.toStringBinary(HConstants.SPLITA_QUALIFIER) + " and qualifier="
+ Bytes.toStringBinary(HConstants.SPLITA_QUALIFIER) + ", from parent " + parent.getRegionNameAsString());
LOG.info("Deleted daughters references, qualifier=" + Bytes.toStringBinary(HConstants.SPLITA_QUALIFIER) +
" and qualifier=" + Bytes.toStringBinary(HConstants.SPLITB_QUALIFIER) +
", from parent " + parent.getRegionNameAsString());
}
public static HRegionInfo getHRegionInfo(
@ -317,4 +318,4 @@ public class MetaEditor {
Bytes.toBytes(sn.getStartcode()));
return p;
}
}
}

2
src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
View File

@ -1816,7 +1816,7 @@ public class HConnectionManager {
} else {
close(true);
}
LOG.debug("The connection to " + this.zooKeeper + " has been closed.");
if (LOG.isTraceEnabled()) LOG.debug("" + this.zooKeeper + " closed.");
}
/**

8
src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlockIndex.java
View File

@ -746,8 +746,8 @@ public class HFileBlockIndex {
totalBlockUncompressedSize +=
blockWriter.getUncompressedSizeWithoutHeader();
if (LOG.isDebugEnabled()) {
LOG.debug("Wrote a " + numLevels + "-level index with root level at pos "
if (LOG.isTraceEnabled()) {
LOG.trace("Wrote a " + numLevels + "-level index with root level at pos "
+ out.getPos() + ", " + rootChunk.getNumEntries()
+ " root-level entries, " + totalNumEntries + " total entries, "
+ StringUtils.humanReadableInt(this.totalBlockOnDiskSize) +
@ -782,9 +782,11 @@ public class HFileBlockIndex {
rootChunk = curInlineChunk;
curInlineChunk = new BlockIndexChunk();
LOG.info("Wrote a single-level " + description + " index with "
if (LOG.isTraceEnabled()) {
LOG.trace("Wrote a single-level " + description + " index with "
+ rootChunk.getNumEntries() + " entries, " + rootChunk.getRootSize()
+ " bytes");
}
rootChunk.writeRoot(out);
}

4
src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java
View File

@ -331,8 +331,10 @@ public class HFileReaderV2 extends AbstractHFileReader {
if (evictOnClose && cacheConf.isBlockCacheEnabled()) {
int numEvicted = cacheConf.getBlockCache().evictBlocksByPrefix(name
+ HFile.CACHE_KEY_SEPARATOR);
LOG.debug("On close, file=" + name + " evicted=" + numEvicted
if (LOG.isTraceEnabled()) {
LOG.trace("On close, file=" + name + " evicted=" + numEvicted
+ " block(s)");
}
}
if (closeIStream && istream != null) {
istream.close();

2
src/main/java/org/apache/hadoop/hbase/master/handler/SplitRegionHandler.java
View File

@ -110,7 +110,7 @@ public class SplitRegionHandler extends EventHandler implements TotesHRegionInfo
parent.getEncodedName() + ")", e);
}
}
LOG.info("Handled SPLIT report); parent=" +
LOG.info("Handled SPLIT event; parent=" +
this.parent.getRegionNameAsString() +
" daughter a=" + this.daughters.get(0).getRegionNameAsString() +
"daughter b=" + this.daughters.get(1).getRegionNameAsString());

3
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
View File

@ -1580,7 +1580,6 @@ public class HRegionServer implements HRegionInterface, HBaseRPCErrorHandler,
// Add to online regions if all above was successful.
addToOnlineRegions(r);
LOG.info("addToOnlineRegions is done" + r.getRegionInfo());
// Update ZK, ROOT or META
if (r.getRegionInfo().isRootRegion()) {
RootLocationEditor.setRootLocation(getZooKeeper(),
@ -1598,7 +1597,7 @@ public class HRegionServer implements HRegionInterface, HBaseRPCErrorHandler,
this.serverNameFromMasterPOV);
}
}
LOG.info("Done with post open deploy taks for region=" +
LOG.info("Done with post open deploy task for region=" +
r.getRegionNameAsString() + ", daughter=" + daughter);
}

2
src/main/java/org/apache/hadoop/hbase/regionserver/SplitTransaction.java
View File

@ -393,7 +393,7 @@ public class SplitTransaction {
// that it's possible for the master to miss an event.
do {
if (spins % 10 == 0) {
LOG.info("Still waiting on the master to process the split for " +
LOG.debug("Still waiting on the master to process the split for " +
this.parent.getRegionInfo().getEncodedName());
}
Thread.sleep(100);

4
src/main/java/org/apache/hadoop/hbase/util/BloomFilterFactory.java
View File

@ -173,12 +173,12 @@ public final class BloomFilterFactory {
CacheConfig cacheConf, BloomType bloomType, int maxKeys,
HFile.Writer writer) {
if (!isGeneralBloomEnabled(conf)) {
LOG.debug("Bloom filters are disabled by configuration for "
LOG.trace("Bloom filters are disabled by configuration for "
+ writer.getPath()
+ (conf == null ? " (configuration is null)" : ""));
return null;
} else if (bloomType == BloomType.NONE) {
LOG.debug("Bloom filter is turned off for the column family");
LOG.trace("Bloom filter is turned off for the column family");
return null;
}