Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-25617 Revisit the span names (#2998) 

Signed-off-by: Guanghao Zhang <zghao@apache.org>
This commit is contained in:
Duo Zhang 2021-03-01 09:47:00 +08:00 committed by Duo Zhang
parent f6ff519dd0
commit 8d68f8cd1c
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncConnectionImpl.java
View File

@ -424,12 +424,12 @@ class AsyncConnectionImpl implements AsyncConnection {
} }
}); });
return future; return future;
}, getClass().getName() + ".getHbck"); }, "AsyncConnection.getHbck");
} }
@Override @Override
public Hbck getHbck(ServerName masterServer) throws IOException { public Hbck getHbck(ServerName masterServer) throws IOException {
Span span = TraceUtil.createSpan(getClass().getName() + ".getHbck") Span span = TraceUtil.createSpan("AsyncConnection.getHbck")
.setAttribute(TraceUtil.SERVER_NAME_KEY, masterServer.getServerName()); .setAttribute(TraceUtil.SERVER_NAME_KEY, masterServer.getServerName());
try (Scope scope = span.makeCurrent()) { try (Scope scope = span.makeCurrent()) {
// we will not create a new connection when creating a new protobuf stub, and for hbck there // we will not create a new connection when creating a new protobuf stub, and for hbck there

2
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRegionLocator.java
View File

@ -98,7 +98,7 @@ class AsyncRegionLocator {
private <T> CompletableFuture<T> tracedLocationFuture(Supplier<CompletableFuture<T>> action, private <T> CompletableFuture<T> tracedLocationFuture(Supplier<CompletableFuture<T>> action,
Function<T, List<String>> getRegionNames, TableName tableName, String methodName) { Function<T, List<String>> getRegionNames, TableName tableName, String methodName) {
Span span = createTableSpan(getClass().getSimpleName() + "." + methodName, tableName); Span span = createTableSpan("AsyncRegionLocator." + methodName, tableName);
try (Scope scope = span.makeCurrent()) { try (Scope scope = span.makeCurrent()) {
CompletableFuture<T> future = action.get(); CompletableFuture<T> future = action.get();
FutureUtils.addListener(future, (resp, error) -> { FutureUtils.addListener(future, (resp, error) -> {

2
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionFactory.java
View File

@ -305,6 +305,6 @@ public class ConnectionFactory {
} }
}); });
return future; return future;
}, ConnectionFactory.class.getSimpleName() + ".createAsyncConnection"); }, "ConnectionFactory.createAsyncConnection");
} }
} }