Add back custom version injection, but set it to the raw HBASE_VERSION (#3)

This reverts commit f556810b52 (#2).
This commit is contained in:
Bryan Beaudreault 2021-12-20 09:52:57 -05:00 committed by GitHub
parent f556810b52
commit 8debdaace4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 2 deletions

View File

@ -80,6 +80,10 @@ fi
RELEASE="${RELEASE}.${BUILD_NUMBER}" RELEASE="${RELEASE}.${BUILD_NUMBER}"
FULL_BUILD_VERSION="${HBASE_VERSION}-${RELEASE}" FULL_BUILD_VERSION="${HBASE_VERSION}-${RELEASE}"
# Add into MAVEN_ARGS because we added this property in hbase-common/pom.xml so we
# could accurately reflect the full build version in the UI and elsewhere.
MAVEN_ARGS="$MAVEN_ARGS -Dhubspot.build.version=$HBASE_VERSION"
# #
# Dump generated env vars into rc file # Dump generated env vars into rc file
# #

View File

@ -31,6 +31,10 @@
<name>Apache HBase - Common</name> <name>Apache HBase - Common</name>
<description>Common functionality for HBase</description> <description>Common functionality for HBase</description>
<properties>
<hubspot.build.version>${project.version}</hubspot.build.version>
</properties>
<build> <build>
<resources> <resources>
<resource> <resource>
@ -76,7 +80,7 @@
<configuration> <configuration>
<target> <target>
<replace file="${project.build.outputDirectory}/hbase-default.xml" <replace file="${project.build.outputDirectory}/hbase-default.xml"
token="@@@VERSION@@@" value="${project.version}" /> token="@@@VERSION@@@" value="${hubspot.build.version}" />
</target> </target>
</configuration> </configuration>
<goals> <goals>
@ -92,7 +96,7 @@
<property name="generated.sources" location="${project.build.directory}/generated-sources"/> <property name="generated.sources" location="${project.build.directory}/generated-sources"/>
<exec executable="bash" failonerror="true"> <exec executable="bash" failonerror="true">
<arg line="${basedir}/src/saveVersion.sh ${project.version} ${generated.sources}/java"/> <arg line="${basedir}/src/saveVersion.sh ${hubspot.build.version} ${generated.sources}/java"/>
</exec> </exec>
</target> </target>
</configuration> </configuration>