From 90b339a4f2e959f5e7a28237f2b591f40bebb3d5 Mon Sep 17 00:00:00 2001
From: Nick Dimiduk <ndimiduk@apache.org>
Date: Mon, 22 Jun 2020 15:22:21 -0700
Subject: [PATCH] HBASE-24567 Create release should url-encode all characters
 when building git uri

By default, `urllib.quote` will skipp over `/` characters, which are
valid for use in passwords.

Signed-off-by: stack <stack@apache.org>
Signed-off-by: Matt Foley <mattf@apache.org>
---
 dev-support/create-release/release-util.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/dev-support/create-release/release-util.sh b/dev-support/create-release/release-util.sh
index 2297ee7a9c1..3e9506b46fe 100755
--- a/dev-support/create-release/release-util.sh
+++ b/dev-support/create-release/release-util.sh
@@ -412,8 +412,8 @@ function git_clone_overwrite {
     echo "[INFO] clone will be of the gitbox repo for ${PROJECT}."
     if [ -n "${ASF_USERNAME}" ] && [ -n "${ASF_PASSWORD}" ]; then
       # Ugly!
-      encoded_username=$(python -c "import urllib; print urllib.quote('''$ASF_USERNAME''')")
-      encoded_password=$(python -c "import urllib; print urllib.quote('''$ASF_PASSWORD''')")
+      encoded_username=$(python -c "import urllib; print urllib.quote('''$ASF_USERNAME''', '')")
+      encoded_password=$(python -c "import urllib; print urllib.quote('''$ASF_PASSWORD''', '')")
       GIT_REPO="https://$encoded_username:$encoded_password@${asf_repo}"
     else
       GIT_REPO="https://${asf_repo}"