Apache/hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-24454 - Read ioErrorStartTime to local temporary variable to avoid issue when it is set to -1 between greater than zero check and calculation of error duration (#1816)

Browse Source 
Signed-off-by Anoop Sam John <anoopsamjohn@apache.org>
This commit is contained in:
jacob-leblanc 2020-05-31 00:06:40 -04:00 committed by stack
parent 61fa21e657
commit 90b66544f0
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java
View File

@ -1139,8 +1139,10 @@ public class BucketCache implements BlockCache, HeapSize {
*/ */
private void checkIOErrorIsTolerated() { private void checkIOErrorIsTolerated() {
long now = EnvironmentEdgeManager.currentTime(); long now = EnvironmentEdgeManager.currentTime();
if (this.ioErrorStartTime > 0) { // Do a single read to a local variable to avoid timing issue - HBASE-24454
if (cacheEnabled && (now - ioErrorStartTime) > this.ioErrorsTolerationDuration) { long ioErrorStartTimeTmp = this.ioErrorStartTime;
if (ioErrorStartTimeTmp > 0) {
if (cacheEnabled && (now - ioErrorStartTimeTmp) > this.ioErrorsTolerationDuration) {
LOG.error("IO errors duration time has exceeded " + ioErrorsTolerationDuration + LOG.error("IO errors duration time has exceeded " + ioErrorsTolerationDuration +
"ms, disabling cache, please check your IOEngine"); "ms, disabling cache, please check your IOEngine");
disableCache(); disableCache();