Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-13638 Put copy constructor is shallow 

Deep copy the cell list

Signed-off-by: Elliott Clark <eclark@apache.org>
This commit is contained in:
Changgeng Li 2015-06-01 10:27:44 -07:00 committed by Elliott Clark
parent b552b9ef32
commit 93148719ba
2 changed files with 44 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hbase-client/src/main/java/org/apache/hadoop/hbase/client/Put.java
View File

@ -123,7 +123,7 @@ public class Put extends Mutation implements HeapSize, Comparable<Row> {
this(putToCopy.getRow(), putToCopy.ts);
this.familyMap = new TreeMap<byte [], List<Cell>>(Bytes.BYTES_COMPARATOR);
for(Map.Entry<byte [], List<Cell>> entry: putToCopy.getFamilyCellMap().entrySet()) {
this.familyMap.put(entry.getKey(), entry.getValue());
this.familyMap.put(entry.getKey(), new ArrayList<Cell>(entry.getValue()));
}
this.durability = putToCopy.durability;
for (Map.Entry<String, byte[]> entry : putToCopy.getAttributesMap().entrySet()) {

43
hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestPut.java Normal file
View File

@ -0,0 +1,43 @@
/**
*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.hadoop.hbase.client;
import org.apache.hadoop.hbase.util.Bytes;
import org.junit.Test;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertNotEquals;
public class TestPut {
@Test
public void testCopyConstructor() {
Put origin = new Put(Bytes.toBytes("ROW-01"));
byte[] family = Bytes.toBytes("CF-01");
byte[] qualifier = Bytes.toBytes("Q-01");
origin.addColumn(family, qualifier, Bytes.toBytes("V-01"));
Put clone = new Put(origin);
assertEquals(origin.getCellList(family), clone.getCellList(family));
origin.addColumn(family, qualifier, Bytes.toBytes("V-02"));
//They should have different cell lists
assertNotEquals(origin.getCellList(family), clone.getCellList(family));
}
}