HBASE-2085 StringBuffer -> StringBuilder - conversion of references as necessary

git-svn-id: https://svn.apache.org/repos/asf/hadoop/hbase/trunk@894950 13f79535-47bb-0310-9956-ffa450edef68

CHANGES.txt

@@ -276,6 +276,8 @@ Release 0.21.0 - Unreleased
    HBASE-2083  [EC2] HDFS DataNode no longer required on master
    HBASE-2084  [EC2] JAVA_HOME handling broken
    HBASE-2036  Use Configuration instead of HBaseConfiguration (Enis Soztutar via Stack)
+   HBASE-2085  StringBuffer -> StringBuilder - conversion of references as necessary
+               (Kay Kay via Stack)
 
   NEW FEATURES
    HBASE-1901  "General" partitioner for "hbase-48" bulk (behind the api, write

src/contrib/stargate/src/java/org/apache/hadoop/hbase/stargate/client/Client.java

@@ -106,7 +106,7 @@ public class Client {
     do {
       cluster.lastHost = cluster.nodes.get(i);
       try {
-        StringBuffer sb = new StringBuffer();
+        StringBuilder sb = new StringBuilder();
         sb.append("http://");
         sb.append(cluster.lastHost);
         sb.append(path);

src/contrib/stargate/src/java/org/apache/hadoop/hbase/stargate/model/TableRegionModel.java

@@ -81,7 +81,7 @@ public class TableRegionModel implements Serializable {
    */
   @XmlAttribute
   public String getName() {
-    StringBuffer sb = new StringBuffer();
+    StringBuilder sb = new StringBuilder();
     sb.append(table);
     sb.append(',');
     sb.append(Bytes.toString(startKey));

src/java/org/apache/hadoop/hbase/HColumnDescriptor.java

@@ -487,7 +487,7 @@ public class HColumnDescriptor implements WritableComparable<HColumnDescriptor>
    */
   @Override
   public String toString() {
-    StringBuffer s = new StringBuffer();
+    StringBuilder s = new StringBuilder();
     s.append('{');
     s.append(HConstants.NAME);
     s.append(" => '");

src/java/org/apache/hadoop/hbase/HTableDescriptor.java

@@ -463,7 +463,7 @@ public class HTableDescriptor implements WritableComparable<HTableDescriptor> {
    */
   @Override
   public String toString() {
-    StringBuffer s = new StringBuffer();
+    StringBuilder s = new StringBuilder();
     s.append('{');
     s.append(HConstants.NAME);
     s.append(" => '");

src/java/org/apache/hadoop/hbase/client/Delete.java

@@ -273,7 +273,7 @@ public class Delete implements Writable, Row, Comparable<Row> {
    */
   @Override
   public String toString() {
-    StringBuffer sb = new StringBuffer();
+    StringBuilder sb = new StringBuilder();
     sb.append("row=");
     sb.append(Bytes.toString(this.row));
     sb.append(", ts=");

src/java/org/apache/hadoop/hbase/client/Get.java

@@ -276,7 +276,7 @@ public class Get implements Writable {
    */
   @Override
   public String toString() {
-    StringBuffer sb = new StringBuffer();
+    StringBuilder sb = new StringBuilder();
     sb.append("row=");
     sb.append(Bytes.toString(this.row));
     sb.append(", maxVersions=");

src/java/org/apache/hadoop/hbase/client/Put.java

@@ -404,7 +404,7 @@ public class Put implements HeapSize, Writable, Row, Comparable<Row> {
    */
   @Override
   public String toString() {
-    StringBuffer sb = new StringBuffer();
+    StringBuilder sb = new StringBuilder();
     sb.append("row=");
     sb.append(Bytes.toString(this.row));
     sb.append(", families={");

src/java/org/apache/hadoop/hbase/client/Result.java

@@ -374,7 +374,7 @@ public class Result implements Writable {
    */
   @Override
   public String toString() {
-    StringBuffer sb = new StringBuffer();
+    StringBuilder sb = new StringBuilder();
     sb.append("keyvalues=");
     if(isEmpty()) {
       sb.append("NONE");

src/java/org/apache/hadoop/hbase/client/Scan.java

@@ -403,7 +403,7 @@ public class Scan implements Writable {
    */
   @Override
   public String toString() {
-    StringBuffer sb = new StringBuffer();
+    StringBuilder sb = new StringBuilder();
     sb.append("startRow=");
     sb.append(Bytes.toString(this.startRow));
     sb.append(", stopRow=");

src/java/org/apache/hadoop/hbase/io/ImmutableBytesWritable.java

@@ -204,7 +204,7 @@ implements WritableComparable<ImmutableBytesWritable> {
    */
   @Override
   public String toString() { 
-    StringBuffer sb = new StringBuffer(3*this.bytes.length);
+    StringBuilder sb = new StringBuilder(3*this.bytes.length);
     for (int idx = 0; idx < this.bytes.length; idx++) {
       // if not the first, put a blank separator in
       if (idx != 0) {

src/java/org/apache/hadoop/hbase/io/TimeRange.java

@@ -149,7 +149,7 @@ public class TimeRange implements Writable {
   
   @Override
   public String toString() {
-    StringBuffer sb = new StringBuffer();
+    StringBuilder sb = new StringBuilder();
     sb.append("maxStamp=");
     sb.append(this.maxStamp);
     sb.append(", minStamp=");

src/java/org/apache/hadoop/hbase/mapreduce/BuildTableIndex.java

@@ -87,7 +87,7 @@ public class BuildTableIndex {
     String iconfFile = null;
     String indexDir = null;
     String tableName = null;
-    StringBuffer columnNames = null;
+    StringBuilder columnNames = null;
 
     // parse args
     for (int i = 0; i < args.length - 1; i++) {
@@ -100,7 +100,7 @@ public class BuildTableIndex {
       } else if ("-table".equals(args[i])) {
         tableName = args[++i];
       } else if ("-columns".equals(args[i])) {
-        columnNames = new StringBuffer(args[++i]);
+        columnNames = new StringBuilder(args[++i]);
         while (i + 1 < args.length && !args[i + 1].startsWith("-")) {
           columnNames.append(" ");
           columnNames.append(args[++i]);

src/test/org/apache/hadoop/hbase/mapreduce/DisabledBecauseVariableSubstTooLargeExceptionTestTableIndex.java

@@ -131,7 +131,7 @@ public class DisabledBecauseVariableSubstTooLargeExceptionTestTableIndex extends
   }
 
   private String createIndexConfContent() {
-    StringBuffer buffer = new StringBuffer();
+    StringBuilder buffer = new StringBuilder();
     buffer.append("<configuration><column><property>" +
       "<name>hbase.column.name</name><value>" + Bytes.toString(INPUT_FAMILY) +
       "</value></property>");