Apache/hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-2049 Cleanup HLog binary log output

Browse Source 
git-svn-id: https://svn.apache.org/repos/asf/hadoop/hbase/trunk@891843 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Michael Stack 2009-12-17 19:03:36 +00:00
parent d225c7576c
commit 962236ed99
2 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGES.txt
View File

@ -235,6 +235,7 @@ Release 0.21.0 - Unreleased
HBASE-2031 When starting HQuorumPeer, try to match on more than 1 address HBASE-2031 When starting HQuorumPeer, try to match on more than 1 address
HBASE-2043 Shell's scan broken HBASE-2043 Shell's scan broken
HBASE-2044 HBASE-1822 removed not-deprecated APIs HBASE-2044 HBASE-1822 removed not-deprecated APIs
HBASE-2049 Cleanup HLog binary log output (Dave Latham via Stack)
NEW FEATURES NEW FEATURES
HBASE-1901 "General" partitioner for "hbase-48" bulk (behind the api, write HBASE-1901 "General" partitioner for "hbase-48" bulk (behind the api, write

14
src/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java
View File

@ -480,7 +480,7 @@ public class HLog implements HConstants, Syncable {
LOG.debug("Found " + sequenceNumbers.size() + " hlogs to remove " + LOG.debug("Found " + sequenceNumbers.size() + " hlogs to remove " +
" out of total " + this.outputfiles.size() + "; " + " out of total " + this.outputfiles.size() + "; " +
"oldest outstanding seqnum is " + oldestOutstandingSeqNum + "oldest outstanding seqnum is " + oldestOutstandingSeqNum +
" from region " + Bytes.toString(oldestRegion)); " from region " + Bytes.toStringBinary(oldestRegion));
} }
if (sequenceNumbers.size() > 0) { if (sequenceNumbers.size() > 0) {
for (Long seq : sequenceNumbers) { for (Long seq : sequenceNumbers) {
@ -493,7 +493,7 @@ public class HLog implements HConstants, Syncable {
oldestRegion: getOldestRegion(oldestOutstandingSeqNum); oldestRegion: getOldestRegion(oldestOutstandingSeqNum);
LOG.info("Too many hlogs: logs=" + countOfLogs + ", maxlogs=" + LOG.info("Too many hlogs: logs=" + countOfLogs + ", maxlogs=" +
this.maxLogs + "; forcing flush of region with oldest edits: " + this.maxLogs + "; forcing flush of region with oldest edits: " +
Bytes.toString(regionToFlush)); Bytes.toStringBinary(regionToFlush));
} }
return regionToFlush; return regionToFlush;
} }
@ -1098,7 +1098,7 @@ public class HLog implements HConstants, Syncable {
LinkedList<HLogEntry> queue = logEntries.get(regionName); LinkedList<HLogEntry> queue = logEntries.get(regionName);
if (queue == null) { if (queue == null) {
queue = new LinkedList<HLogEntry>(); queue = new LinkedList<HLogEntry>();
LOG.debug("Adding queue for " + Bytes.toString(regionName)); LOG.debug("Adding queue for " + Bytes.toStringBinary(regionName));
logEntries.put(regionName, queue); logEntries.put(regionName, queue);
} }
HLogEntry hle = new HLogEntry(val, key); HLogEntry hle = new HLogEntry(val, key);
@ -1145,7 +1145,7 @@ public class HLog implements HConstants, Syncable {
ExecutorService threadPool = ExecutorService threadPool =
Executors.newFixedThreadPool(logWriterThreads); Executors.newFixedThreadPool(logWriterThreads);
for (final byte[] key : logEntries.keySet()) { for (final byte[] key : logEntries.keySet()) {
Thread thread = new Thread(Bytes.toString(key)) { Thread thread = new Thread(Bytes.toStringBinary(key)) {
@Override @Override
public void run() { public void run() {
LinkedList<HLogEntry> entries = logEntries.get(key); LinkedList<HLogEntry> entries = logEntries.get(key);
@ -1188,7 +1188,7 @@ public class HLog implements HConstants, Syncable {
logWriters.put(key, wap); logWriters.put(key, wap);
if (LOG.isDebugEnabled()) { if (LOG.isDebugEnabled()) {
LOG.debug("Creating new hlog file writer for path " LOG.debug("Creating new hlog file writer for path "
+ logfile + " and region " + Bytes.toString(key)); + logfile + " and region " + Bytes.toStringBinary(key));
} }
if (old != null) { if (old != null) {
@ -1211,12 +1211,12 @@ public class HLog implements HConstants, Syncable {
} }
if (LOG.isDebugEnabled()) { if (LOG.isDebugEnabled()) {
LOG.debug("Applied " + count + " total edits to " LOG.debug("Applied " + count + " total edits to "
+ Bytes.toString(key) + " in " + Bytes.toStringBinary(key) + " in "
+ (System.currentTimeMillis() - threadTime) + "ms"); + (System.currentTimeMillis() - threadTime) + "ms");
} }
} catch (IOException e) { } catch (IOException e) {
e = RemoteExceptionHandler.checkIOException(e); e = RemoteExceptionHandler.checkIOException(e);
LOG.warn("Got while writing region " + Bytes.toString(key) LOG.warn("Got while writing region " + Bytes.toStringBinary(key)
+ " log " + e); + " log " + e);
e.printStackTrace(); e.printStackTrace();
} }