From 97cb1d71bc4f426ceca1de86b86bafcd9799be20 Mon Sep 17 00:00:00 2001 From: tedyu Date: Mon, 24 Oct 2016 01:39:02 -0700 Subject: [PATCH] HBASE-16929 Move default method of shipped to Shipper interface - revert pending finding cause for Phoenix compilation error --- .../apache/hadoop/hbase/regionserver/RegionScanner.java | 9 +++++++++ .../org/apache/hadoop/hbase/regionserver/Shipper.java | 2 +- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionScanner.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionScanner.java index fb1fe5d8669..8d8c051c4ec 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionScanner.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionScanner.java @@ -115,4 +115,13 @@ public interface RegionScanner extends InternalScanner, Shipper { */ boolean nextRaw(List result, ScannerContext scannerContext) throws IOException; + + /** + * Empty implementation to provide compatibility for user migrating from 1.X + * @see HBASE-16626 + */ + @Override + default void shipped() throws IOException { + // do nothing + } } \ No newline at end of file diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Shipper.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Shipper.java index 8fa393b1864..fb66f51f62e 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Shipper.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Shipper.java @@ -33,5 +33,5 @@ public interface Shipper { * Called after a batch of rows scanned and set to be returned to client. Any in between cleanup * can be done here. */ - default void shipped() throws IOException { } + void shipped() throws IOException; }